Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce rubocop layout rules #495

Merged
merged 3 commits into from
May 11, 2023
Merged

Enforce rubocop layout rules #495

merged 3 commits into from
May 11, 2023

Conversation

Splines
Copy link
Member

@Splines Splines commented May 8, 2023

The only thing I've done here, is to run the following command inside the app folder (with rubocop version 1.50.2).

rubocop --config ../.rubocop.yml --fix-layout

See the docs for this command. There are no logical changes, just pure layout stuff. E.g. consistent line indentation, a newline at the end of every file. Also note that this does not affect .erb files at all.

⚠ Squash #494 beforehand.

Splines added 3 commits May 9, 2023 00:03
The old version does not work with the Ruby LSP VS Code extension.
@Splines Splines requested a review from fosterfarrell9 May 8, 2023 22:21
@Splines Splines self-assigned this May 8, 2023
@Splines Splines changed the title Enforce rubocop layout rultes Enforce rubocop layout rules May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #495 (2de4b26) into mampf-next (b119ec9) will decrease coverage by 0.08%.
The diff coverage is 46.93%.

@@              Coverage Diff               @@
##           mampf-next     #495      +/-   ##
==============================================
- Coverage       66.64%   66.56%   -0.08%     
==============================================
  Files             311      311              
  Lines            9362     9376      +14     
==============================================
+ Hits             6239     6241       +2     
- Misses           3123     3135      +12     
Impacted Files Coverage Δ
app/abilities/medium_ability.rb 60.86% <0.00%> (ø)
app/helpers/announcements_helper.rb 36.36% <ø> (ø)
app/helpers/application_helper.rb 38.57% <0.00%> (ø)
app/helpers/assignments_helper.rb 36.36% <ø> (ø)
app/helpers/chapters_helper.rb 66.66% <ø> (ø)
app/helpers/clickers_helper.rb 22.22% <ø> (ø)
app/helpers/courses_helper.rb 43.75% <ø> (ø)
app/helpers/items_helper.rb 45.45% <ø> (ø)
app/helpers/lectures_helper.rb 35.18% <0.00%> (ø)
app/helpers/lessons_helper.rb 42.85% <ø> (ø)
... and 79 more

@Splines Splines merged commit 5f7c956 into mampf-next May 11, 2023
@Splines Splines deleted the formatting/rubocop-layout branch May 11, 2023 15:05
@Splines Splines mentioned this pull request May 15, 2023
@Splines Splines mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants