Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Release 1.6.0 #511

Merged
merged 30 commits into from
Jun 6, 2023
Merged

Continuous Release 1.6.0 #511

merged 30 commits into from
Jun 6, 2023

Conversation

fosterfarrell9 and others added 29 commits April 10, 2023 14:14
Bring back v1.5.1 hotfixes from main to mampf-next
* Update rubocop version

The old version does not work with the Ruby LSP VS Code extension.

* Exclude some rubocop metrics (for now)

* Reflect rubocop version update in lockfile
* Update rubocop version

The old version does not work with the Ruby LSP VS Code extension.

* Exclude some rubocop metrics (for now)

* Enforce rubocop layout rules
* Fix ghost links in nested tabs

* Fix spacing in media card
* Prevent flickering when quiz search results show up

* Remove user slug from StackOverflow link

* Get rid of unnecessary function
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #511 (cb46762) into main (f6dd9d2) will decrease coverage by 0.14%.
The diff coverage is 47.31%.

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   66.64%   66.50%   -0.14%     
==========================================
  Files         311      311              
  Lines        9362     9413      +51     
==========================================
+ Hits         6239     6260      +21     
- Misses       3123     3153      +30     
Impacted Files Coverage Δ
app/abilities/medium_ability.rb 60.86% <0.00%> (ø)
app/helpers/announcements_helper.rb 36.36% <ø> (ø)
app/helpers/application_helper.rb 38.57% <0.00%> (ø)
app/helpers/assignments_helper.rb 36.36% <ø> (ø)
app/helpers/chapters_helper.rb 66.66% <ø> (ø)
app/helpers/clickers_helper.rb 22.22% <ø> (ø)
app/helpers/courses_helper.rb 43.75% <ø> (ø)
app/helpers/items_helper.rb 45.45% <ø> (ø)
app/helpers/lectures_helper.rb 35.18% <0.00%> (ø)
app/helpers/lessons_helper.rb 42.85% <ø> (ø)
... and 80 more

* use default version of commontator gem instead of own fork

* enforce rubocop layout

* refactor customization of create comment action and add comments
@Splines Splines requested a review from fosterfarrell9 May 30, 2023 10:29
@Splines Splines marked this pull request as ready for review May 31, 2023 10:04
@Splines Splines merged commit 55e9cb3 into main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants