-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename network controller properties state property #1074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ba0d6e6
to
e51c954
Compare
PR has been rebased onto main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well.
e51c954
to
a2d88a7
Compare
a2d88a7
to
e36e986
Compare
@cryptodev-2s FYI if you use the "Update branch" button on GitHub, it will preserve any PR approvals. Rebasing manually requires re-approving. |
This PR renames properties network controller state property to networkDetails. Related issue [#1019](https://app.zenhub.com/workspaces/core-621e46b4d7103800171d1b02/issues/gh/metamask/core/1019)
This PR renames properties network controller state property to networkDetails. Related issue [#1019](https://app.zenhub.com/workspaces/core-621e46b4d7103800171d1b02/issues/gh/metamask/core/1019)
This PR renames properties network controller state property to networkDetails.
Related issue #1019