Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the "Limit my search to the map area" behaviour & toggle to the Cesium map in the data catalog #2069

Closed
robyngit opened this issue Oct 14, 2022 · 2 comments · Fixed by #2127
Closed

Add the "Limit my search to the map area" behaviour & toggle to the Cesium map in the data catalog #2069

robyngit opened this issue Oct 14, 2022 · 2 comments · Fixed by #2127
Assignees
@robyngit
Labels
cesium enhancement
Milestone
2.25.0

Comments

@robyngit
Copy link
Member

robyngit commented Oct 14, 2022 •
edited
Loading

In the beta release of Cesium, we still need to add the "Limit my search to the map area" toggle that exists in the Google map. Right now search results are always limited to the map area.

Part of issue #1720
@robyngit robyngit self-assigned this Oct 14, 2022
@robyngit robyngit changed the title Add the "Limit my search to the map area" toggle Add the "Limit my search to the map area" toggle to the Cesium map in the data catalog Oct 14, 2022
@robyngit
Copy link
Member Author

Update: I thought that the search results were being updated when the view extent in Cesium changed because the results are refreshed each time you zoom in and out. However, I see now that the results refresh because the map just updates the geohash level in the SolrResults which triggers a new query. The query is not limited by a bounding box, so this issue covers both:

  • Adding the ability to limit the search results to just the visible area
  • Add the toggle to turn this behaviour on and off

@robyngit robyngit changed the title Add the "Limit my search to the map area" toggle to the Cesium map in the data catalog Add the "Limit my search to the map area" behaviour & toggle to the Cesium map in the data catalog Dec 13, 2022
@robyngit robyngit added this to the 2.24.0 milestone Mar 15, 2023
robyngit added a commit that referenced this issue Mar 28, 2023
@robyngit
Standardize formatting in Geohash related models
5be539d 
Relates to #2069
robyngit added a commit that referenced this issue Mar 28, 2023
@robyngit
Work on CatalogSearch connectors [WIP]
8e35e70 
- fix SpatialFilter
- Add Filters-Map connector
- Identify TODOs

Relates to #2069
robyngit added a commit that referenced this issue Mar 29, 2023
@robyngit
Ensure SolrResults hear when spatial filter added
d458ad1 
Also add new methods to Filters-Search connector

Relates to #2069
robyngit added a commit that referenced this issue Mar 29, 2023
@robyngit
Remove logic from Geohash model (now in Sp. Filter)
aa28250 
Make the Geohash layer simply draw geohashes when counts are set on the model.

Relates to #2069
robyngit added a commit that referenced this issue Mar 29, 2023
@robyngit
Standardize formatting in Filters collection
bf6cc2d 
Relates to #2069
robyngit added a commit that referenced this issue Mar 29, 2023
@robyngit
Standardize formatting in Map & MapAssets
a6bc546 
Relates to #2069
robyngit added a commit that referenced this issue Mar 29, 2023
@robyngit
Add facet counts to Geohash Layer from Search
fa7579e 
Create a Map-Search connector that finds/adds a Geohash layer and keeps it
up-to-date with SolrResults. Also, in the Filters-Search connector, set facets
on the SolrResults when the Spatial filter changes in the Filters collection.

Relates to #2069
robyngit added a commit that referenced this issue Mar 30, 2023
@robyngit
Create Map-Search-Filters connector
6808fcf 
Move connector/model logic from CatalogSearchView to Map-Search-Filters

Relates to #2069
robyngit added a commit that referenced this issue Mar 30, 2023
@robyngit
Add init options to MapSearchFilters connector
2898796 
- Create a Geohash layer and Spatial Filter by default, but allow changing options
- Allow passing in Map, SolrResults, and/or Filters models/collections, default to appModel config
- Other minor Cesium map fixes

Relates to #2069
robyngit added a commit that referenced this issue Mar 30, 2023
@robyngit
Add init options to CatalogSearchView
d7e2557 
Relates to #2069
robyngit added a commit that referenced this issue Mar 31, 2023
@robyngit
Small refactor to toggle map spatial filter [WIP]
14bbfd6 
- Add Geohash model & collection - use in both the SpatialFilter and CesiumGeohash
- Move logic from SpatialFilter and CesiumGeohash to Geohash model/collection
- Ensure that mapModel is always added as a property of new layers (e.g. new geohash layers)
- Fix a small SolrResults bug with facetting

Relates to #2069
robyngit added a commit that referenced this issue Apr 3, 2023
@robyngit
Make more efficient spatial queries [WIP]
84a6183 
- "merge" geohashes into one where possible for purposes of querying to reduce the length of the query
- Add lots of other functionality to Geohash model and Geohashes collection required for getting spatial filters to work and for rendering geohashes in Cesium

Relates to #2069
robyngit added a commit that referenced this issue Apr 5, 2023
@robyngit
Fix bugs with constructing spatial queries
261025d 
Relates to #2069
robyngit added a commit that referenced this issue Apr 7, 2023
@robyngit
Style/connect catalog<->map buttons; move CSS
f02d1a2 
- Move the catalogSearchView into it's own CSS file to keep it more manageable [WIP]
- Add and style the show/hide map button & filter by extent toggle. Connect them to their actions.

Relates to: #2069, #2065
@robyngit
Copy link
Member Author

robyngit commented Apr 7, 2023

Done in the feature-#1720-cesium-data-catalog branch

@robyngit robyngit linked a pull request Apr 20, 2023 that will close this issue
New CatalogSearchView with configurable filters & Cesium map #2127
Merged
@robyngit robyngit modified the milestones: 2.24.0, 2.25.0 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robyngit robyngit

Labels
cesium enhancement
Projects
None yet
Milestone
2.25.0
Development

Successfully merging a pull request may close this issue.

New CatalogSearchView with configurable filters & Cesium map NCEAS/metacatui
1 participant
@robyngit