New CatalogSearchView with configurable filters & Cesium map #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it's configured to use it instead of the older version Fixes #2064
- Replace similar calculations with the view's getDegreesFromCartesian function - Make the getDegreesFromCartesian less repetitive by iterating through the position keys - Also standardize formatting in the view Relates to #1720
- Make CesiumGeohash an extension of CesiumVectorData instead of MapAsset - Add Geohash specific properties to the CesiumGeohash model (e.g. precisionAltMap, bounds, level, geohashes, etc.) - Add a ToJSON function to the CesiumGeohash model that converts geohash & search result information to a JSON object - Create listeners for updating Geohashes when the bounds & altitude change - Add ability to update the data source in the CesiumVectorData model - Always set ClampToGround to true for geohashes Relates to #1720, #2063, #2070, #2076
Cesium throws an error when the latitude is -90 Relates to #1720
To improve performance when map is focused on poles or zoomed in and at ground level perspective Relates to #1720
When it's configured to use it instead of the older version Fixes #2064
- Replace similar calculations with the view's getDegreesFromCartesian function - Make the getDegreesFromCartesian less repetitive by iterating through the position keys - Also standardize formatting in the view Relates to #1720
- Make CesiumGeohash an extension of CesiumVectorData instead of MapAsset - Add Geohash specific properties to the CesiumGeohash model (e.g. precisionAltMap, bounds, level, geohashes, etc.) - Add a ToJSON function to the CesiumGeohash model that converts geohash & search result information to a JSON object - Create listeners for updating Geohashes when the bounds & altitude change - Add ability to update the data source in the CesiumVectorData model - Always set ClampToGround to true for geohashes Relates to #1720, #2063, #2070, #2076
Cesium throws an error when the latitude is -90 Relates to #1720
To improve performance when map is focused on poles or zoomed in and at ground level perspective Relates to #1720
…m/NCEAS/metacatui into feature-#1720-cesium-data-catalog
Also externalize the main template Relates to #1520
|
@rushirajnenuji this is ready to test when you're ready! I'm doing some testing on my own and also working on writing unit tests and a guide (in docs), but that's no reason to wait on a review. |
|
The latest version, as of the time of writing, is deployed at https://test.arcticdata.io/ |
robyngit
added
ADC CI-14
Plus minor modifications/fixes to Geohashes Issue #1720
Fix the remove spatial filters method Issue #1720
- Add types to models - Minor fixes found during testing Issue #1720
- Add guide for customizing the CatalogSearchView - Add guide for configuring Cesium in portals - Update the general Cesium guide - Other minor doc updates - Minor CSS tweak Issue #1720
rushirajnenuji
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
I tested this PR on my local development instance and the changes look good. I did run into some performance issues (loading latency) but it looks like we already have a ticket for that (#2145).
Thank you for working on this feature, this will be a great addition to MetacatUI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the new
CatalogSearchView, set to replace both theDataCatalogViewandDataCatalogViewWithFilters(although these will remain functional but deprecated). The updated catalog view takes advantage of the Filters infrastructure, initially designed for portals, to enable straightforward configuration of repository search filters. Additionally, it transitions from Google Maps to the more versatile Cesium map, which offers a 3D globe representation of the world instead of a 2D projection.While a few tasks remain, this feature is nearing completion. As such, I am opening this draft pull request to start gathering feedback.
Here's a current snapshot of the
CatalogSearchViewwithin the ADC: