mixed precision exchange #1318

mcallic2 · 2023-08-03T19:40:12Z

Description
All real values will be calculated as r8_kind

Fixes # (issue)

How Has This Been Tested?
Autotools with intel and gcc

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
New check tests, if applicable, are included
make distcheck passes

)

…DL#1125) Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>

NOAA-GFDL#1120)

Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>

…A-GFDL#1131)

…tory file issues (NOAA-GFDL#1139)

…1142)

…1109)

…o dy (NOAA-GFDL#1169)

* fix: fms2 io performance update for domain_reads (NOAA-GFDL#1226) * fix: fms2 io performance update for compressed writes (NOAA-GFDL#1227) * chore: build/log updates for patch (NOAA-GFDL#1247) Co-authored-by: uramirez8707 <49168881+uramirez8707@users.noreply.github.com> Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>

…re, and fms_mod (NOAA-GFDL#1239) (NOAA-GFDL#1258) * feat: mixed precision axis_utils2 (NOAA-GFDL#1104) * feat: mixed precision fms_mod (NOAA-GFDL#1147) * feat: horiz interp mixed precision (NOAA-GFDL#1067) * mixed precision sat_vapor_pressure (NOAA-GFDL#1095) * feat: add mixed precision axis_utils unit tests (NOAA-GFDL#1172) * fix: move type definitions to before first usage to fix nvhpc bug (NOAA-GFDL#1187) * fix: change allocatable type for intel errors (NOAA-GFDL#1221) Co-authored-by: Caitlyn McAllister <65364559+mcallic2@users.noreply.github.com> Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com>

…list. (NOAA-GFDL#1246)

…t nmls in mpp scripts (NOAA-GFDL#1158)

…OAA-GFDL#1152)

)

…1064) BREAKING CHANGE: This commit removes mpp_io_mod and fms_io_mod, along with other routines that use the modules, from default compilation. The -Duse_deprecated_io CPP flag or --enable-deprecated-io configure time flag can be used to enable their compilation.

…FDL#1285)

mlee03 · 2023-08-04T13:00:54Z

@mcallic2, while we're at it, would you mind fixing all the "Warning: Conversion from INTEGER(4) to INTEGER(8)" in exchange?

This reverts commit d400726.

mlee03

@mcallic2 can you merge in mixedmode?

mlee03 · 2023-08-11T15:08:03Z

.github/workflows/Dockerfile.gnu

@@ -0,0 +1,68 @@
+#***********************************************************************


should .github be updated to that in mixedmode?

this may have been me messing up the mixedmode merge, really not sure though

@mcallic2 this

exchange/xgrid.F90

test_fms/exchange/test_xgrid.F90

mcallic2 · 2023-08-11T22:07:56Z

@mcallic2 can you merge in mixedmode?

@mlee03 this is up to date with mixedmode

mcallic2 · 2023-08-17T14:15:44Z

./github directory is bugging me

J-Lentz and others added 30 commits February 1, 2023 08:28

fix: misspellings and rename variable in yaml_parser.F90 (NOAA-GFDL#1127

485d631

)

fix: module and local variable name conflicts in time_interp (NOAA-GF…

35a5f2a

…DL#1125) Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>

docs: Correct instructions to build without MPI (NOAA-GFDL#1128)

ba9c712

fix: pointer to allocatable in amip_interp_type (NOAA-GFDL#1106)

15df841

feat: log_diag_field_info updates from diag rewrite (NOAA-GFDL#1117)

f0e8cab

fix: remove implied save for valid_types variables in sat_vapor_pres_k (

ec2020a

NOAA-GFDL#1120)

revert: log_diag_field_info argument changes (NOAA-GFDL#1136)

4526cc9

Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>

feat: refactored send_data math (field buffer update) functions. (NOA…

6255971

…A-GFDL#1131)

fix: adds tags to nested do loops in fms_diag_fieldbuff.fh to fix his…

74d8e73

…tory file issues (NOAA-GFDL#1139)

fix - gnu and pgi issue with class(*) in send_data3d (NOAA-GFDL#1149)

9b83c8c

feat: extend string interface in fms_string_utils_mod (NOAA-GFDL#…

9339b88

…1142)

fix: add omp directives for race condition in tridiagonal (NOAA-GFDL#…

0ff254e

…1109)

fix: missing if statement in PR NOAA-GFDL#1149 (NOAA-GFDL#1155)

6362657

fix: time_manager missing changes from year to yr, month to mo, day t…

7188e3a

…o dy (NOAA-GFDL#1169)

chore: update changelog and version numbers for release (NOAA-GFDL#1167)

8a78fac

chore: append dev to version number post-release (NOAA-GFDL#1179)

003b8e1

fix: replace current_peset_num with 'n' which should be the active pe…

af15993

…list. (NOAA-GFDL#1246)

fix: gcc class(*) bug workaround for character arrays (NOAA-GFDL#1163)

de03798

fix: improve error messages in fms2_io (NOAA-GFDL#1183)

16d71a2

feat: fms2_io unpack data (NOAA-GFDL#1231)

22c498e

fix: improve doxygen comment for tranlon (NOAA-GFDL#1257)

cf5035f

fix: ifort 2022.3.0 & greater ICE bug in alltoall test + missing inpu…

ecc1361

…t nmls in mpp scripts (NOAA-GFDL#1158)

fix: checks placed before allocating pointers passed into routines (N…

783019f

…OAA-GFDL#1152)

fix: continuation line syntax for fms2_io error messages (NOAA-GFDL#1265

5e130ef

)

fix: update doc site deployment action(NOAA-GFDL#1078)

84b330a

fix: warnings in test_mpp_nesting.F90 (NOAA-GFDL#1118)

ef8b5e3

fix: field exists check for io update (NOAA-GFDL#1193)

cbceb9f

J-Lentz and others added 11 commits July 27, 2023 13:21

fix: add fms_stacksize.c to fms_c_src_files in CMakeLists.txt (NOAA-G…

0e4a675

…FDL#1285)

chore: update changelog for 2023.02 release (NOAA-GFDL#1306)

c7a70e7

chore: append dev to version number post-release (NOAA-GFDL#1308)

c982456

CI: update gnu image and add dockerfile (NOAA-GFDL#1206)

0efc2e5

merge mixedmode

2e1697a

include directory not needed

48875a8

reals to r8_kind

56b1f4e

this can all get vetoed, but asthetics

9836d90

adding explicit r8 real values

246964d

more explicit r8_kind

ddc780d

int to real

997f7bf

mcallic2 marked this pull request as ready for review August 3, 2023 20:12

mcallic2 requested review from bensonr, thomas-robinson and rem1776 as code owners August 3, 2023 20:12

mcallic2 requested review from J-Lentz and mlee03 August 3, 2023 20:12

mcallic2 added 3 commits August 7, 2023 11:48

explicit i8

38e53b2

this removes i8 conversion warning

d400726

Revert "this removes i8 conversion warning"

4d870a0

This reverts commit d400726.

mlee03 reviewed Aug 11, 2023

View reviewed changes

exchange/xgrid.F90 Outdated Show resolved Hide resolved

exchange/xgrid.F90 Outdated Show resolved Hide resolved

exchange/xgrid.F90 Outdated Show resolved Hide resolved

exchange/xgrid.F90 Outdated Show resolved Hide resolved

test_fms/exchange/test_xgrid.F90 Outdated Show resolved Hide resolved

mcallic2 added 3 commits August 14, 2023 10:44

all constants stay in r8 kind so these were unecessary

69f67a2

forgot these constants

cf2c385

fixes .github directory

d1baa9f

mcallic2 closed this Aug 17, 2023

mcallic2 deleted the exchange branch October 6, 2023 17:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mixed precision exchange #1318

mixed precision exchange #1318

mcallic2 commented Aug 3, 2023

mlee03 commented Aug 4, 2023 •

edited

Loading

mlee03 left a comment

mlee03 Aug 11, 2023

mcallic2 Aug 11, 2023 •

edited

Loading

mlee03 Aug 16, 2023

mcallic2 commented Aug 11, 2023

mcallic2 commented Aug 17, 2023

		@@ -0,0 +1,68 @@
		#***********************************************************************

mixed precision exchange #1318

mixed precision exchange #1318

Conversation

mcallic2 commented Aug 3, 2023

mlee03 commented Aug 4, 2023 • edited Loading

mlee03 left a comment

Choose a reason for hiding this comment

mlee03 Aug 11, 2023

Choose a reason for hiding this comment

mcallic2 Aug 11, 2023 • edited Loading

Choose a reason for hiding this comment

mlee03 Aug 16, 2023

Choose a reason for hiding this comment

mcallic2 commented Aug 11, 2023

mcallic2 commented Aug 17, 2023

mlee03 commented Aug 4, 2023 •

edited

Loading

mcallic2 Aug 11, 2023 •

edited

Loading