Enable GCF loader to filter singleton GCFs #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2023
This was referenced Nov 20, 2023
Merged
This was referenced Nov 27, 2023
Merged
gcroci2
approved these changes
Dec 11, 2023
CunliangGeng
force-pushed
the
11-15-filter_singleton_gcf
branch
from
5139465
to
b60b24c
Compare
This was referenced Dec 11, 2023
Add keep_singleton to the base class of GCF loader
CunliangGeng
force-pushed
the
11-15-filter_singleton_gcf
branch
from
b60b24c
to
1324ba4
Compare
Merge activity
|
CunliangGeng
added a commit
that referenced
this pull request
Dec 19, 2023
Similar to PR #181, this PR adds a new parameter `keep_singleton` in the method `get_mfs` of MolecularFamily loader. Major changes: - change class property `families` to method `get_mfs` - add parameter `keep_singleton` to method `get_mfs`
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new parameter
keep_singletonin the methodget_gcfs()of GCF loader. With that, users can choose to keep the singleton GCFs (A GCF that contains only one BGC member) or not in the loading process.