-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove class SingletonFamily
and MF attribute id
#192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
Merged
This was referenced Dec 4, 2023
Merged
CunliangGeng
force-pushed
the
11-27-filter_singleton_MFs
branch
from
December 5, 2023 15:54
476e8d0
to
1c029a0
Compare
CunliangGeng
force-pushed
the
11-27-remove_SingletonFamily_and_id
branch
from
December 5, 2023 15:54
583384f
to
b4ab6e1
Compare
CunliangGeng
force-pushed
the
11-27-filter_singleton_MFs
branch
from
December 11, 2023 13:03
1c029a0
to
66dd7ac
Compare
CunliangGeng
force-pushed
the
11-27-remove_SingletonFamily_and_id
branch
from
December 11, 2023 13:04
b4ab6e1
to
5ad51fe
Compare
This was referenced Dec 11, 2023
gcroci2
reviewed
Dec 13, 2023
gcroci2
reviewed
Dec 13, 2023
gcroci2
reviewed
Dec 13, 2023
gcroci2
reviewed
Dec 13, 2023
gcroci2
approved these changes
Dec 13, 2023
CunliangGeng
force-pushed
the
11-27-filter_singleton_MFs
branch
from
December 14, 2023 08:33
66dd7ac
to
79ec809
Compare
CunliangGeng
force-pushed
the
11-27-remove_SingletonFamily_and_id
branch
from
December 14, 2023 08:33
5ad51fe
to
a0d5ea7
Compare
CunliangGeng
force-pushed
the
11-27-filter_singleton_MFs
branch
from
December 19, 2023 13:21
79ec809
to
7894c6d
Compare
CunliangGeng
force-pushed
the
11-27-remove_SingletonFamily_and_id
branch
from
December 19, 2023 13:21
fa32a02
to
fc2f8d5
Compare
Merge activity
|
CunliangGeng
force-pushed
the
11-27-filter_singleton_MFs
branch
from
December 19, 2023 13:25
7894c6d
to
efe2148
Compare
Class MolecularFamily can be used to represent singleton molecular family.
We let the loaders like `GNPSMolecularFamilyLoader` to decide how to assign family id to singleton MFs.
Co-authored-by: Giulia Crocioni <55382553+gcroci2@users.noreply.github.com>
Co-authored-by: Giulia Crocioni <55382553+gcroci2@users.noreply.github.com>
CunliangGeng
force-pushed
the
11-27-remove_SingletonFamily_and_id
branch
from
December 19, 2023 13:27
fc2f8d5
to
70a61b5
Compare
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Singleton molecular families can be well represented with the class
MolecularFamily
, and it's not needed to keep a specific classSingletonFamily
for them, so this PR removed it.As for the family id, the class
SingleFamily
automatically set it (i.e."singleton-" + uuid
), while the classMolecularFamily
requires users to provide the family id during initiation. It makes more sense to let users or loaders of molecular family to decide how to set family id. So in theGNPSMolecularFamilyLoader
class, the name of singleton MF was updated to"singleton-" + spectrum_id
.The attribute
id
of MolecularFamily is unused by anywhere, so it's removed too.