remove loading of optional data #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2023
Merged
Merged
This was referenced Dec 12, 2023
CunliangGeng
force-pushed
the
12-12-deprecate_loading_chemical_classes
branch
from
06340eb
to
e164eaa
Compare
CunliangGeng
force-pushed
the
12-12-remove_loading_optional_data
branch
from
db67ce5
to
9b08108
Compare
CunliangGeng
force-pushed
the
12-12-deprecate_loading_chemical_classes
branch
from
e164eaa
to
a0410ca
Compare
CunliangGeng
force-pushed
the
12-12-remove_loading_optional_data
branch
from
9b08108
to
256692a
Compare
CunliangGeng
force-pushed
the
12-12-deprecate_loading_chemical_classes
branch
from
a0410ca
to
42793a8
Compare
CunliangGeng
force-pushed
the
12-12-remove_loading_optional_data
branch
from
256692a
to
f7bd16d
Compare
CunliangGeng
force-pushed
the
12-12-deprecate_loading_chemical_classes
branch
from
42793a8
to
ecb03e8
Compare
CunliangGeng
force-pushed
the
12-12-remove_loading_optional_data
branch
from
f7bd16d
to
ee755e0
Compare
CunliangGeng
force-pushed
the
12-12-remove_loading_optional_data
branch
from
ee755e0
to
8517df0
Compare
CunliangGeng
force-pushed
the
12-12-remove_loading_optional_data
branch
from
8517df0
to
0f4bc7c
Compare
gcroci2
approved these changes
Dec 21, 2023
Merge activity
|
CunliangGeng
force-pushed
the
12-12-deprecate_loading_chemical_classes
branch
from
262b6b5
to
b714bed
Compare
Base automatically changed from
12-12-deprecate_loading_chemical_classes
to
dev
January 24, 2024 15:24
To keep the loading process simple, the loading of GNPS params.xml file is removed. If the GNPS params data is needed in the future, a specific loader in the module `GNPS` should be created for that.
To keep the loading process simple, the loading of description text is removed. A specific loader could be added in the future if these info is necessary in NPLinker. Note that the method `_load_optional` is then totally removed.
CunliangGeng
force-pushed
the
12-12-remove_loading_optional_data
branch
from
0f4bc7c
to
f0235cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional data, including GNPS params.xml file and description text, are not needed for core business of NPLinker. To keep the loading process simple (to keep refactored NPLinker as a minimum viable product), the loading of optional data is removed. If these data are needed in the future, specific loaders should be added for them.