Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to End solution for editing rules on a User Interface. #100

Closed
wants to merge 21 commits into from
Closed

End to End solution for editing rules on a User Interface. #100

wants to merge 21 commits into from

Conversation

cskcvarma
Copy link

@cskcvarma cskcvarma commented Jun 11, 2024 •
edited
Loading

Description

This pull request provides an end-to-end solution for editing rules on a user interface. The implemented functionalities include:

  1. Rendering user GitHub repositories.
  2. Collecting YAML files from each repository.
  3. Rendering the contents of YAML files.
  4. Updating a rule.
  5. Saving and committing the changes to GitHub.

Related Issue

This pull request does not relate to existing issues, it is an enhancement.

Motivation and Context

The changes are necessary to provide a seamless way for users to edit rules within a user interface, thus improving user experience and efficiency in managing YAML file contents and rules.

How Has This Been Tested?

The changes have been tested by:

  1. Rendering multiple user GitHub repositories.
  2. Successfully collecting and rendering YAML files from these repositories.
  3. Updating rules in the YAML files.
  4. Committing changes to GitHub repositories.
  5. Testing was conducted in a local development environment with multiple test repositories to ensure functionality
    and reliability.
    Screenshots (if appropriate):
    ezgif-5-b34ec009f3

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. (The work is still in progress, and I'm yet to complete unit tests for new functionality)
  • All new and existing tests passed.

jskrajareddy21 and others added 2 commits May 29, 2024 10:55
@jskrajareddy21 @asingamaneni
optimization and additional columns to detailed stats (Nike-Inc#96)
f702f39 
* spark expectation optimization, detailed stats adding start and end time and job metadata info

* updated code for storing row dq results in detailed stats table

* Update writer.py

* initial edit

* Adding tests for the stats table writer

* Adding test for detailed stats table

* Fixing lint issues

* Update setup.md

* Adding the missing test

---------

Co-authored-by: krishnam Jagadapi <krishnam.jagadapi@nike.com>
Co-authored-by: Ashok Singamaneni <ashok.singamaneni@nike.com>
@mikita-sakalouski
[FEATURE] Loosen pluggy version (Nike-Inc#94)
b615fd2 
* feat: loosen pluggy version

* feat: update poetry lock

* feat: update lock

* fix: pyspark version
amaldevk88 and others added 17 commits June 24, 2024 11:33
@amaldevk88
Integrating the notifications to Zoom Webhook (Nike-Inc#83)
d3edcde 
* Update CONTRIBUTORS.md

* Added zoom notification
@shinga
Reverting error_df optimization to fix Nike-Inc#101 (Nike-Inc#104)
d860ae5 
Co-authored-by: Arthur Shing <arthur.shing@nike.com>
@cskcvarma
Initializing theme files (#11)
e4040a9 
* Adding a basic mantine theme file. It will be updated as the code base develops.

Any colors or gaps will not be hardcoded.

They should first be defined in the theme and then should be used in the code.

* updating .gitignore
@cskcvarma
Includes a comprehensive test setup with mock data and support struct…
cd321fb 
…ure. (#12)

setting up tests in the future will be easier.
@cskcvarma
9 tech debt setup public private routing (#13)
b3aed3c 
* Working version of routing

* Implemented routing, however tests for the login page needs to figured out.
@cskcvarma
implemented notification from mantine (#14)
523bbb8
@cskcvarma
8 feature implement login functionality using GitHub oauth (#15)
af41438 
* clean up

* A simple but beautiful login page

* Github Oauth setup
@cskcvarma
16 tech debt complete todos (#17)
012e688 
* Fixed testing setup and have all tests for OAuth.

* Fixed remaining TODOs, added tests.

* Adding a DEVELOPER.md and .env.example
@cskcvarma
Restructuring + layout (#19)
3ae5b11
@cskcvarma
adding yaml file
05e92eb
@cskcvarma
20 load list of organizations on the left cell (#21)
27c1b95 
* WIP

* fetch user name before rendering main page

* implement api for user repos

* show available repos on the left hand side

* Rendering an un nested list of files

* rendering yaml files in each project

* implemented rules table
@cskcvarma
editing rules.yaml
202457e
@cskcvarma
Build a working version (#22)
269afbb 
* working modal

* working flow

* Updated repos list

* Refactored CommitsList.tsx and apis

* minor fixes
@jskrajareddy21 @asingamaneni @cskcvarma
optimization and additional columns to detailed stats (Nike-Inc#96)
a522d17 
* spark expectation optimization, detailed stats adding start and end time and job metadata info

* updated code for storing row dq results in detailed stats table

* Update writer.py

* initial edit

* Adding tests for the stats table writer

* Adding test for detailed stats table

* Fixing lint issues

* Update setup.md

* Adding the missing test

---------

Co-authored-by: krishnam Jagadapi <krishnam.jagadapi@nike.com>
Co-authored-by: Ashok Singamaneni <ashok.singamaneni@nike.com>
@mikita-sakalouski @cskcvarma
[FEATURE] Loosen pluggy version (Nike-Inc#94)
388ec81 
* feat: loosen pluggy version

* feat: update poetry lock

* feat: update lock

* fix: pyspark version
@amaldevk88 @cskcvarma
Integrating the notifications to Zoom Webhook (Nike-Inc#83)
f90515f 
* Update CONTRIBUTORS.md

* Added zoom notification
@cskcvarma
cleaning up .env.example
35ee0b8
@cskcvarma cskcvarma closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asingamaneni asingamaneni Awaiting requested review from asingamaneni asingamaneni is a code owner

@Umeshsp22 Umeshsp22 Awaiting requested review from Umeshsp22 Umeshsp22 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cskcvarma @jskrajareddy21 @mikita-sakalouski @amaldevk88 @shinga