Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReleasePre][2022.11.22] FI of dev into main #9317

Merged
merged 7 commits into from
Nov 28, 2022
Merged

[ReleasePre][2022.11.22] FI of dev into main #9317

merged 7 commits into from
Nov 28, 2022

Conversation

lyndaidaii
Copy link
Contributor

No description provided.

advay26 and others added 6 commits November 11, 2022 14:51
@advay26
[A11y] Correct role attribute for package lists (#9303)
429d3a0 
* initial commit

* removed 'alert' role from Search heading

* removed header role too, unneccessary for h1 elements
@advay26
[A11y] Change role attribute of Recaptcha iframe (#9306)
41a7375 
* changed recaptcha role

* Changed role to document
@advay26
[A11y] Removed incorrect role attribute from breadcrumb headings (#9311
f472850 
)
@joelverhagen
Update to latest client SDK to bring .NET 7 support onto the framewor…
d68cd0c 
…ks tab (#9312)

* Add .NET 7 TFMs
* Update to latest NuGet SDK and System.Data.SqlClient to resolve CG alerts

I had to modify the TFM resolution code to resolve an Obsolete warning. Existing UT coverage is good and they all passed.

Resolve #9313
@keylime-unicorn
make aria-hidden elements not focusable (#9314)
a65d4cf
@vlada-shubina
Changed dotnet new example (#9309)
3db2816 
Co-authored-by: Joel Verhagen <jver@microsoft.com>

The syntax has changed in .NET 7. Since .NET 7 is GA'd and is being actively adopted, we'll update NuGet.org to reflect that.
@lyndaidaii lyndaidaii requested a review from a team as a code owner November 22, 2022 18:21
joelverhagen
joelverhagen previously approved these changes Nov 22, 2022
View reviewed changes
advay26
advay26 previously approved these changes Nov 22, 2022
View reviewed changes
@keylime-unicorn
[A11y] Remove aria-hidden attribute for prefix reserved element (#9315)
bd8070c 
* make aria-hidden elements not focusable

* remove aria-hidden attribute

* fix merge dev into branch
@lyndaidaii lyndaidaii merged commit f3d98cf into main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelverhagen joelverhagen joelverhagen approved these changes

@keylime-unicorn keylime-unicorn keylime-unicorn approved these changes

@advay26 advay26 advay26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lyndaidaii @joelverhagen @keylime-unicorn @advay26 @vlada-shubina