[16.0][OU-ADD] sale: migration #4004

hoangtiendung070797 · 2023-07-03T09:46:10Z

Migration module

legalsylvain · 2023-07-03T09:48:11Z

/ocabot migration sale

Could you take a look on the red CI ?

Depends on :

account_payment : [16.0][OU-ADD] account_payment: Nothing to do #3920

remytms

Thanks for this job. Some remarks. I may be wrong on some of them.

openupgrade_scripts/scripts/sale/16.0.1.2/upgrade_analysis_work.txt

hoangtiendung070797 · 2023-07-04T01:53:15Z

@remytms Thanks for your help. I will check it again

huguesdk

here are some changes needed to be able to run the migration. i did not look into all changes.

openupgrade_scripts/scripts/sale/16.0.1.2/post-migration.py

openupgrade_scripts/scripts/sale/16.0.1.2/pre-migration.py

…_file [IMP [16.0] *: update analysis files

huguesdk

thanks for this great work! here are some needed changes.

openupgrade_scripts/scripts/sale/16.0.1.2/pre-migration.py

openupgrade_scripts/scripts/sale/16.0.1.2/upgrade_analysis_work.txt

openupgrade_scripts/scripts/sale/16.0.1.2/pre-migration.py

huguesdk · 2023-07-10T08:36:43Z

openupgrade_scripts/scripts/sale/16.0.1.2/upgrade_analysis_work.txt

+sale         / sale.order.line          / analytic_distribution_stored_char (char): NEW isfunction: function, stored
+# NOTHINGH TO DO: handle by ORM


this is a new computed field (analytic_distribution) coming from the analytic.mixin model. its compute function is _compute_analytic_distribution(). a fast precomputation could be useful.

@huguesdk analytic_distribution_stored_char fields is not found in source code. Can you show me where it is located?

This the reason why we need the new analysis file because sometime it cause us some confusion
BTW, for the field analytic_distribution_stored_char which is in my lates analysis file it is analytic_distribution, i have created a dynamic method at https://github.com/OCA/OpenUpgrade/pull/4070/files#diff-90f733d1f5eba9ea514de973136064df20f321c35c019951653200d2c0e582d3R501-R515.
Please make a test with this situation then let me know it is working ok then i will decide to have it in the openupgrade_160

openupgrade_scripts/scripts/sale/16.0.1.2/pre-migration.py

openupgrade_scripts/scripts/sale/16.0.1.2/upgrade_analysis_work.txt

openupgrade_scripts/scripts/sale/16.0.1.2/pre-migration.py

hoangtiendung070797 · 2023-07-11T01:24:08Z

@huguesdk Thanks bro. I have learned more things from you lately 👍 . I will check it again

Merge upstream 16 230710 01

* [MISC] apriori: add section for Viindoo * [MISC] apriori: add project section for Viindoo --------- Co-authored-by: Tran Truong Son <truongson290893@gmail.com>

* [OU-ADD] website_profile: Nothing to do * Update docsource/modules150-160.rst --------- Co-authored-by: Roy Le <43790414+royleviindoo@users.noreply.github.com>

* [OU-ADD] account_edi_ubl: Nothing to do * Update modules150-160.rst --------- Co-authored-by: Roy Le <43790414+royleviindoo@users.noreply.github.com>

* [OU-ADD] account_sale_timesheet: Nothing to do * Update modules150-160.rst --------- Co-authored-by: Roy Le <43790414+royleviindoo@users.noreply.github.com>

* [OU-ADD] stock: migration * imp --------- Co-authored-by: Roy Le <roy.le@viindoo.com>

"viin_website_image_optimization_disable": "viin_web_editor",

legalsylvain · 2023-08-01T14:50:50Z

Hi @hoangtiendung070797 looks like your PR requires a rebase.
Thanks !

chienandalu

Are you finishing this @hoangtiendung070797 ?

remi-filament · 2023-10-12T12:27:22Z

openupgrade_scripts/scripts/sale/16.0.1.2/upgrade_analysis_work.txt

+ir.actions.server: sale.model_sale_order_action_share (noupdate switched)
+# DONE: pre-migration: noupdate switched to 0
+
+NEW ir.config_parameter: sale.default_invoice_email_template (noupdate)


Hi @hoangtiendung070797 thanks for your work on this PR !
Actually this one is not new, it was already existing in v15.0 here : https://github.com/odoo/odoo/blob/7d90bce4c90cb77f2268332a5f1225cd884ac674/addons/sale/models/res_config_settings.py#L59-L65 (except it was not loaded from data but directly in Python model).

Obviously when migrating I get the following errors :

2023-10-12 12:15:55,539 65829 INFO lf_20231011_v16mig odoo.modules.loading: loading sale/data/sale_data.xml 2023-10-12 12:15:55,556 65829 ERROR lf_20231011_v16mig odoo.sql_db: bad query: INSERT INTO "ir_config_parameter" ("create_date", "create_uid", "key", "value", "write_date", "write_uid") VALUES ('2023-10-12 12:15:52.952317', 1, 'sale.default_invoice_email_template', '11', '2023-10-12 12:15:52.952317', 1) RETURNING "id" ERROR: duplicate key value violates unique constraint "ir_config_parameter_key_uniq" DETAIL: Key (key)=(sale.default_invoice_email_template) already exists.

You should probably add a XML id on that parameter in pre_migration using openupgrade.add_xmlid() function (https://github.com/OCA/openupgradelib/blob/d0aee908031876a95dc36c7a9a2c847186155aa2/openupgradelib/openupgrade.py#L1288)

marielejeune · 2023-11-27T10:44:06Z

Hi @hoangtiendung070797 , do you plan to rebase and finish this PR? We'll need it for our migration script. Thanks.

duong77476-viindoo · 2023-11-27T10:45:47Z

Hi @hoangtiendung070797 , do you plan to rebase and finish this PR? We'll need it for our migration script. Thanks.

Hi , im in charge now, i will create a new PR

OCA-git-bot added this to the 16.0 milestone Jul 3, 2023

OCA-git-bot mentioned this pull request Jul 3, 2023

Migration to version 16.0 #3681

Open

hoangtiendung070797 force-pushed the v16_mig_sale branch 3 times, most recently from b1c8341 to 3570e55 Compare July 3, 2023 10:14

legalsylvain added the Blocked by dependency label Jul 3, 2023

remytms reviewed Jul 3, 2023

View reviewed changes

This was referenced Jul 3, 2023

[16.0][OU-ADD] sale_crm: Nothing to do #3996

Merged

[16.0][OU-ADD] sale_management #4014

Merged

[16.0][OD-ADD] sale_product_matrix: Nothing to do #3999

Open

[16.0][OU-ADD] sale_stock #4015

Merged

legalsylvain mentioned this pull request Jul 4, 2023

[ADD] documentation : Use case SQL Constraint deleted #3915

Merged

hoangtiendung070797 force-pushed the v16_mig_sale branch from 3570e55 to 9614320 Compare July 4, 2023 08:11

huguesdk suggested changes Jul 6, 2023

View reviewed changes

openupgrade_scripts/scripts/sale/16.0.1.2/post-migration.py Outdated Show resolved Hide resolved

openupgrade_scripts/scripts/sale/16.0.1.2/pre-migration.py Show resolved Hide resolved

legalsylvain mentioned this pull request Jul 6, 2023

[16.0][OU-ADD] sale_purchase #4061

Closed

hoangtiendung070797 force-pushed the v16_mig_sale branch 2 times, most recently from 37e9a76 to 64c15de Compare July 7, 2023 01:52

duong77476-viindoo and others added 2 commits July 7, 2023 14:48

[IMP] update analysis files

6217a9f

Merge pull request Viindoo#350 from duong77476/v16_imp_update_analyst…

215dd08

…_file [IMP [16.0] *: update analysis files

legalsylvain mentioned this pull request Jul 7, 2023

[16.0][OD-ADD] sale_product_configurator: Nothing to do #4064

Merged

huguesdk suggested changes Jul 10, 2023

View reviewed changes

hoangtiendung070797 force-pushed the v16_mig_sale branch from 64c15de to 81fd94a Compare July 11, 2023 03:04

royle-vietnam and others added 5 commits July 13, 2023 11:32

Merge remote-tracking branch 'OCA/16.0' into 15.0

146ea7f

Merge pull request Viindoo#388 from SonCrits/merge_upstream_1

6756d94

Merge upstream 16 230710 01

[MISC] apriori: add section for Viindoo (Viindoo#399)

b374300

* [MISC] apriori: add section for Viindoo * [MISC] apriori: add project section for Viindoo --------- Co-authored-by: Tran Truong Son <truongson290893@gmail.com>

[OA-ADD] auth_totp_mail: Nothing to do

9fe1e20

[OU-ADD] stock_sms: nothing to do

022523e

NgoHoangHung and others added 15 commits July 15, 2023 15:00

[OU-ADD] website_profile: migration (Viindoo#453)

c4ab93b

* [OU-ADD] website_profile: Nothing to do * Update docsource/modules150-160.rst --------- Co-authored-by: Roy Le <43790414+royleviindoo@users.noreply.github.com>

[OU-ADD] website_sale_stock: migrate 15 to 16

5e46de1

[OU-ADD] account_edi_ubl: Nothing to do (Viindoo#452)

ae320b2

* [OU-ADD] account_edi_ubl: Nothing to do * Update modules150-160.rst --------- Co-authored-by: Roy Le <43790414+royleviindoo@users.noreply.github.com>

[OU-ADD] account_sale_timesheet: Nothing to do (Viindoo#449)

8b45f9f

* [OU-ADD] account_sale_timesheet: Nothing to do * Update modules150-160.rst --------- Co-authored-by: Roy Le <43790414+royleviindoo@users.noreply.github.com>

[IMP] apriori: rename module

7e7ba42

[FIX] apriori: rename module before merge

fde29a0

[OU-ADD] stock: migration (Viindoo#466)

768110e

* [OU-ADD] stock: migration * imp --------- Co-authored-by: Roy Le <roy.le@viindoo.com>

[FIX] apriori: wrong merge module

defe861

"viin_website_image_optimization_disable": "viin_web_editor",

[OU-ADD] sale_quotation_builder: mig to 16.0

b985fd6

[OU-ADD] sale_purchase: mig to 16.0

c1939de

[OU-ADD] sale_management: mig to 16.0

7de8391

[OU-ADD] website_crm_iap_reveal: nothing to do

7c9207b

[OU-ADD] sale_timesheet: migrate 15.0 to 16.0

677af59

[MIG] sale_project: nothing todo

ca6df35

[OU-ADD] project: migration data

e6dda98

royle-vietnam force-pushed the v16_mig_sale branch 3 times, most recently from 51135ab to 55d01dd Compare July 19, 2023 10:33

[OU-ADD] sale: migration

3a20d38

royle-vietnam force-pushed the v16_mig_sale branch from 55d01dd to 3a20d38 Compare July 19, 2023 10:35

legalsylvain added the needs fixing label Aug 1, 2023

carmenbianca mentioned this pull request Sep 1, 2023

[16.0][OU-ADD] sale_mrp: nothing to do #4116

Merged

chienandalu reviewed Sep 20, 2023

View reviewed changes

remi-filament reviewed Oct 12, 2023

View reviewed changes

legalsylvain mentioned this pull request Oct 20, 2023

[16.0][OU-ADD] mass_mailing_sale: Nothing to do #4174

Merged

1 task

duong77476-viindoo mentioned this pull request Nov 28, 2023

[16.0][OU-ADD] sale: migration #4240

Closed

pedrobaeza closed this Nov 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][OU-ADD] sale: migration #4004

[16.0][OU-ADD] sale: migration #4004

hoangtiendung070797 commented Jul 3, 2023

legalsylvain commented Jul 3, 2023 •

edited

Loading

remytms left a comment

hoangtiendung070797 commented Jul 4, 2023

huguesdk left a comment

huguesdk left a comment

huguesdk Jul 10, 2023

hoangtiendung070797 Jul 11, 2023

duong77476-viindoo Jul 11, 2023

hoangtiendung070797 commented Jul 11, 2023

legalsylvain commented Aug 1, 2023

chienandalu left a comment

remi-filament Oct 12, 2023 •

edited

Loading

marielejeune commented Nov 27, 2023

duong77476-viindoo commented Nov 27, 2023

		sale / sale.order.line / analytic_distribution_stored_char (char): NEW isfunction: function, stored
		# NOTHINGH TO DO: handle by ORM

[16.0][OU-ADD] sale: migration #4004

[16.0][OU-ADD] sale: migration #4004

Conversation

hoangtiendung070797 commented Jul 3, 2023

legalsylvain commented Jul 3, 2023 • edited Loading

remytms left a comment

Choose a reason for hiding this comment

hoangtiendung070797 commented Jul 4, 2023

huguesdk left a comment

Choose a reason for hiding this comment

huguesdk left a comment

Choose a reason for hiding this comment

huguesdk Jul 10, 2023

Choose a reason for hiding this comment

hoangtiendung070797 Jul 11, 2023

Choose a reason for hiding this comment

duong77476-viindoo Jul 11, 2023

Choose a reason for hiding this comment

hoangtiendung070797 commented Jul 11, 2023

legalsylvain commented Aug 1, 2023

chienandalu left a comment

Choose a reason for hiding this comment

remi-filament Oct 12, 2023 • edited Loading

Choose a reason for hiding this comment

marielejeune commented Nov 27, 2023

duong77476-viindoo commented Nov 27, 2023

legalsylvain commented Jul 3, 2023 •

edited

Loading

remi-filament Oct 12, 2023 •

edited

Loading