Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] fieldservice (PM #515 and #577) #230

Merged
merged 4 commits into from
Jun 10, 2019
Merged

[FIX] fieldservice (PM #515 and #577) #230

merged 4 commits into from
Jun 10, 2019

Conversation

osi-scampbell
Copy link
Contributor

This PR fixes Ticket #577 Search Order Error and Ticket #515 Address Type 'Other'. This PR also contains unit tests for fsm_wizard to ensure that Ticket #515 is enforced and the wizard converts Res.Partners to FSM Location/Person properly.

@osi-scampbell osi-scampbell changed the title [WIP][IMP] Tickets #577 and #515 [IMP] Tickets #577 and #515 Jun 3, 2019
@max3903 max3903 added this to the 12.0 milestone Jun 10, 2019
@max3903 max3903 changed the title [IMP] Tickets #577 and #515 [FIX] fieldservice (PM #515 and #577) Jun 10, 2019
@max3903 max3903 added the bug label Jun 10, 2019
patrickrwilson
patrickrwilson approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as intended.

@max3903 max3903 merged commit dec6c20 into OCA:12.0 Jun 10, 2019
@max3903 max3903 deleted the sc_bug_fix_rc12 branch June 10, 2019 23:15
osi-scampbell added a commit to ursais/field-service that referenced this pull request Jun 11, 2019
@osi-scampbell
[WIP][ADD] fsm_server_action
22323d6 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
murtuzasaleh pushed a commit to SerpentConsultingServices/field-service that referenced this pull request Feb 26, 2020
@osi-scampbell @murtuzasaleh
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
fe711ac
murtuzasaleh pushed a commit to SerpentConsultingServices/field-service that referenced this pull request Mar 16, 2020
@osi-scampbell @murtuzasaleh
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
8d618fb
brian10048 pushed a commit to brian10048/field-service that referenced this pull request Jul 21, 2020
@osi-scampbell @brian10048
[WIP][ADD] fsm_server_action
ababf97 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Jan 18, 2021
@osi-scampbell @Murtaza-OSI
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
fe3deb6
Khalid-SerpentCS pushed a commit to ursais/field-service that referenced this pull request Jan 19, 2021
@osi-scampbell @Khalid-SerpentCS
[WIP][ADD] fsm_server_action
9d9b6e6 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Khalid-SerpentCS pushed a commit to ursais/field-service that referenced this pull request Jan 19, 2021
@osi-scampbell @Khalid-SerpentCS
[WIP][ADD] fsm_server_action
fdb0130 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
hparfr pushed a commit to akretion/field-service that referenced this pull request Mar 11, 2021
@osi-scampbell @hparfr
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
d5f445e
hparfr pushed a commit to akretion/field-service that referenced this pull request Mar 11, 2021
@osi-scampbell @hparfr
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
f78e290
Freni-OSI pushed a commit to ursais/field-service that referenced this pull request Apr 19, 2021
@osi-scampbell @Freni-OSI
[WIP][ADD] fsm_server_action
381e46e 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Jan 7, 2022
@osi-scampbell @Murtaza-OSI
[WIP][ADD] fsm_server_action
4dcce09 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
AmmarOfficewalaSerpentCS pushed a commit to ursais/field-service that referenced this pull request Jan 7, 2022
@osi-scampbell @Ammar-OSI
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
b58fc7c
Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Apr 6, 2022
@osi-scampbell @Murtaza-SerpentCS
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
1fd4aa5
Freni-OSI pushed a commit to ursais/field-service that referenced this pull request Apr 6, 2022
@osi-scampbell @Freni-OSI
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
f1469d4
victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Aug 8, 2022
@osi-scampbell @victoralmau
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
13552ec
victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Aug 9, 2022
@osi-scampbell @victoralmau
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
a6fe8e1
victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Oct 5, 2022
@osi-scampbell @victoralmau
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
e1202aa
Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Oct 10, 2022
@osi-scampbell @Murtaza-OSI
[WIP][ADD] fsm_server_action
32f94b8 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
max3903 pushed a commit to ursais/field-service that referenced this pull request Oct 10, 2022
@osi-scampbell @max3903
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
5be3efb
max3903 pushed a commit to ursais/field-service that referenced this pull request Oct 10, 2022
@osi-scampbell @max3903
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
5157eca
Freni-OSI pushed a commit to ursais/field-service that referenced this pull request Oct 19, 2022
@osi-scampbell @Freni-OSI
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
b32e9a8
brian10048 pushed a commit to brian10048/field-service that referenced this pull request Nov 15, 2023
@osi-scampbell @brian10048
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
d550724
brian10048 pushed a commit to brian10048/field-service that referenced this pull request Nov 17, 2023
@osi-scampbell @brian10048
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
cfbc31d
brian10048 pushed a commit to brian10048/field-service that referenced this pull request Nov 27, 2023
@osi-scampbell @brian10048
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
c830252
imlopes pushed a commit to imlopes/field-service that referenced this pull request Aug 12, 2024
@osi-scampbell
[WIP][ADD] fsm_server_action
830783f 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Oct 8, 2024
@osi-scampbell @EdgarRetes
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
b57fdf5
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Oct 21, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
c7a1383 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Oct 23, 2024
@osi-scampbell @EdgarRetes
[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)
3021490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 approved these changes

@patrickrwilson patrickrwilson patrickrwilson approved these changes

@smangukiya smangukiya Awaiting requested review from smangukiya

@brian10048 brian10048 Awaiting requested review from brian10048

Assignees

@osi-scampbell osi-scampbell

Labels
approved bug
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@osi-scampbell @max3903 @patrickrwilson @OCA-git-bot