Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] fieldservice: Add notes on location (PM #596) #231

Merged
merged 8 commits into from
Jun 11, 2019
Merged

[IMP] fieldservice: Add notes on location (PM #596) #231

merged 8 commits into from
Jun 11, 2019

Conversation

osi-scampbell
Copy link
Contributor

@osi-scampbell osi-scampbell commented Jun 4, 2019 •
edited
Loading

This PR adds fax, email, and phone to an FSM Location record as well as implements the state_id/country_id onchange methods from res.partner.

EDIT: Added General Notes to Location as well. Ticket #607

@max3903
Copy link
Member

max3903 commented Jun 4, 2019

@osi-scampbell There is a partner_fax module in OCA/partner-contact. Just add the dependency and the field on the location view.

The onchange methods should call their equivalent on partner_id.

@max3903 max3903 self-requested a review June 4, 2019 04:17
@max3903 max3903 added this to the 12.0 milestone Jun 4, 2019
@osi-scampbell
Copy link
Contributor Author

@osi-scampbell There is a partner_fax module in OCA/partner-contact. Just add the dependency and the field on the location view.

The onchange methods should call their equivalent on partner_id.

I added partner_fax and I added the comment Pat made on the ticket. I don't know how to call their equivalent on partner_id? If Odoo uses delegation inheritance then the methods don't get inherited so I am not sure how to reference them.

@osi-scampbell osi-scampbell changed the title [WIP][IMP] Ticket #596 Location Field updates/additions [IMP] Ticket #596 Location Field updates/additions Jun 4, 2019
@max3903 max3903 changed the title [IMP] Ticket #596 Location Field updates/additions [IMP] fieldservice: Add notes on location (PM #596) Jun 10, 2019
patrickrwilson
patrickrwilson approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add some widgets to the phone and email fields and good to go.

fieldservice/views/fsm_location.xml Outdated Show resolved Hide resolved
fieldservice/views/fsm_location.xml Outdated Show resolved Hide resolved
fieldservice/views/fsm_location.xml Outdated Show resolved Hide resolved
@max3903 max3903 merged commit 290b2b0 into OCA:12.0 Jun 11, 2019
@max3903 max3903 deleted the sc_location_fields branch June 11, 2019 00:00
osi-scampbell added a commit to ursais/field-service that referenced this pull request Jun 11, 2019
@osi-scampbell
[WIP][ADD] fsm_server_action
22323d6 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
murtuzasaleh pushed a commit to SerpentConsultingServices/field-service that referenced this pull request Mar 16, 2020
@osi-scampbell @murtuzasaleh
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
c48ee94
brian10048 pushed a commit to brian10048/field-service that referenced this pull request Jul 21, 2020
@osi-scampbell @brian10048
[WIP][ADD] fsm_server_action
ababf97 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Jan 18, 2021
@osi-scampbell @Murtaza-OSI
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
6dfd916
Khalid-SerpentCS pushed a commit to ursais/field-service that referenced this pull request Jan 19, 2021
@osi-scampbell @Khalid-SerpentCS
[WIP][ADD] fsm_server_action
9d9b6e6 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Khalid-SerpentCS pushed a commit to ursais/field-service that referenced this pull request Jan 19, 2021
@osi-scampbell @Khalid-SerpentCS
[WIP][ADD] fsm_server_action
fdb0130 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
hparfr pushed a commit to akretion/field-service that referenced this pull request Mar 11, 2021
@osi-scampbell @hparfr
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
35b7550
hparfr pushed a commit to akretion/field-service that referenced this pull request Mar 11, 2021
@osi-scampbell @hparfr
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
4958f38
Freni-OSI pushed a commit to ursais/field-service that referenced this pull request Apr 19, 2021
@osi-scampbell @Freni-OSI
[WIP][ADD] fsm_server_action
381e46e 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Jan 7, 2022
@osi-scampbell @Murtaza-OSI
[WIP][ADD] fsm_server_action
4dcce09 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
AmmarOfficewalaSerpentCS pushed a commit to ursais/field-service that referenced this pull request Jan 7, 2022
@osi-scampbell @Ammar-OSI
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
1b32955
Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Apr 6, 2022
@osi-scampbell @Murtaza-SerpentCS
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
9fe06d7
Freni-OSI pushed a commit to ursais/field-service that referenced this pull request Apr 6, 2022
@osi-scampbell @Freni-OSI
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
77bac47
victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Aug 8, 2022
@osi-scampbell @victoralmau
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
2cd17d5
victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Aug 9, 2022
@osi-scampbell @victoralmau
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
96c1c56
victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Oct 5, 2022
@osi-scampbell @victoralmau
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
09c47d5
Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Oct 10, 2022
@osi-scampbell @Murtaza-OSI
[WIP][ADD] fsm_server_action
32f94b8 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
max3903 pushed a commit to ursais/field-service that referenced this pull request Oct 10, 2022
@osi-scampbell @max3903
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
cb34ed3
max3903 pushed a commit to ursais/field-service that referenced this pull request Oct 10, 2022
@osi-scampbell @max3903
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
968c905
Freni-OSI pushed a commit to ursais/field-service that referenced this pull request Oct 19, 2022
@osi-scampbell @Freni-OSI
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
f512d14
brian10048 pushed a commit to brian10048/field-service that referenced this pull request Nov 15, 2023
@osi-scampbell @brian10048
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
409dfd7
brian10048 pushed a commit to brian10048/field-service that referenced this pull request Nov 17, 2023
@osi-scampbell @brian10048
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
7f80b68
brian10048 pushed a commit to brian10048/field-service that referenced this pull request Nov 27, 2023
@osi-scampbell @brian10048
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
473c489
imlopes pushed a commit to imlopes/field-service that referenced this pull request Aug 12, 2024
@osi-scampbell
[WIP][ADD] fsm_server_action
830783f 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Oct 8, 2024
@osi-scampbell @EdgarRetes
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
6c60344
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Oct 21, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
c7a1383 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Oct 23, 2024
@osi-scampbell @EdgarRetes
[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)
48bfcc1
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Nov 15, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
5691997 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Nov 20, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
dc5110b 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Nov 26, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
85ebdba 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Nov 29, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
7ea9cee 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickrwilson patrickrwilson patrickrwilson approved these changes

@max3903 max3903 max3903 approved these changes

@murtuzasaleh murtuzasaleh Awaiting requested review from murtuzasaleh

@brian10048 brian10048 Awaiting requested review from brian10048

Assignees

@osi-scampbell osi-scampbell

Labels
approved needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@osi-scampbell @max3903 @patrickrwilson @OCA-git-bot