Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] fieldservice_agreement #232

Merged
merged 3 commits into from
Jun 11, 2019
Merged

[FIX] fieldservice_agreement #232

merged 3 commits into from
Jun 11, 2019

Conversation

osi-scampbell
Copy link
Contributor

@osi-scampbell osi-scampbell commented Jun 6, 2019 •
edited
Loading

This PR adds notes to Service Profiles, adds a tab on Agreements where users can add Service Profiles, adds tab on FSM Location where users can see the Agreements associated with this location and their Service Profiles. Tickets #: 609, 608, 604

@osi-scampbell osi-scampbell changed the title [WIP][IMP][ADD] Ticket #: 609, 608, 604 FSM Agreement [WIP][IMP][ADD] FSM Agreement improvements Jun 6, 2019
@osi-scampbell osi-scampbell changed the title [WIP][IMP][ADD] FSM Agreement improvements [IMP][ADD] FSM Agreement improvements Jun 9, 2019
@max3903 max3903 changed the title [IMP][ADD] FSM Agreement improvements [IMP] fieldservice_agreement Jun 10, 2019
@max3903 max3903 self-requested a review June 10, 2019 18:30
@max3903 max3903 added the bug label Jun 10, 2019
@max3903 max3903 added this to the 12.0 milestone Jun 10, 2019
patrickrwilson
patrickrwilson approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the service profile notes to the list on locations so you can also see the notes related to the service profile. This allows the user to quickly see details without opening up each profile. Approving this even if that doesn't make it in this update.

fieldservice_agreement/views/fsm_location.xml Outdated Show resolved Hide resolved
@osi-scampbell
[IMP][ADD] Ticket #: 609, 608, 604 fsm_agreement
a270cf2 
[IMP] Add to serviceprofile_ids on agreement

[IMP] Github comments
@max3903 max3903 changed the title [IMP] fieldservice_agreement [FIX] fieldservice_agreement Jun 11, 2019
@max3903 max3903 merged commit 56f3bc8 into OCA:12.0 Jun 11, 2019
@max3903 max3903 deleted the sc_fsm_agree_tix branch June 11, 2019 13:02
osi-scampbell added a commit to ursais/field-service that referenced this pull request Jun 11, 2019
@osi-scampbell
[WIP][ADD] fsm_server_action
22323d6 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
brian10048 pushed a commit to brian10048/field-service that referenced this pull request Jul 21, 2020
@osi-scampbell @brian10048
[WIP][ADD] fsm_server_action
ababf97 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Khalid-SerpentCS pushed a commit to ursais/field-service that referenced this pull request Jan 19, 2021
@osi-scampbell @Khalid-SerpentCS
[WIP][ADD] fsm_server_action
9d9b6e6 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Khalid-SerpentCS pushed a commit to ursais/field-service that referenced this pull request Jan 19, 2021
@osi-scampbell @Khalid-SerpentCS
[WIP][ADD] fsm_server_action
fdb0130 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Freni-OSI pushed a commit to ursais/field-service that referenced this pull request Apr 19, 2021
@osi-scampbell @Freni-OSI
[WIP][ADD] fsm_server_action
381e46e 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
patrickrwilson pushed a commit to patrickrwilson/field-service that referenced this pull request Apr 27, 2021
@osi-scampbell @patrickrwilson
[FIX] fieldservice_agreement (OCA#232)
16cf1ca
patrickrwilson pushed a commit to patrickrwilson/field-service that referenced this pull request Apr 27, 2021
@osi-scampbell @patrickrwilson
[FIX] fieldservice_agreement (OCA#232)
dc33530
Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Jan 7, 2022
@osi-scampbell @Murtaza-OSI
[WIP][ADD] fsm_server_action
4dcce09 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Oct 10, 2022
@osi-scampbell @Murtaza-OSI
[WIP][ADD] fsm_server_action
32f94b8 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
szekawong pushed a commit to xcgd/field-service that referenced this pull request Nov 6, 2023
@osi-scampbell @szekawong
[FIX] fieldservice_agreement (OCA#232)
a40aa97
imlopes pushed a commit to imlopes/field-service that referenced this pull request Aug 12, 2024
@osi-scampbell
[WIP][ADD] fsm_server_action
830783f 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
imlopes pushed a commit to camptocamp/field-service that referenced this pull request Sep 9, 2024
@osi-scampbell
[FIX] fieldservice_agreement (OCA#232)
8da579e
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Oct 21, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
c7a1383 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Nov 15, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
5691997 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Nov 20, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
dc5110b 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Nov 26, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
85ebdba 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
EdgarRetes pushed a commit to ursais/field-service that referenced this pull request Nov 29, 2024
@osi-scampbell @EdgarRetes
[WIP][ADD] fsm_server_action
7ea9cee 
[ADD] Templates

[WIP] Testing

[IMP] FSM Emails

[ADD] FSM Stage Server Action

[IMP] ir.server.action in pavlov_media

[IMP] Remove dependency conflict

[IMP] Cite OCA manifest

[IMP] Remove Dependency

[IMP] Auto Config for User

[IMP] Small changes

[FIX] fieldservice (PM OCA#515 and OCA#577) (OCA#230)

[IMP] fieldservice: Add notes on location (PM OCA#596) (OCA#231)

[FIX] fieldservice_agreement (OCA#232)

[ADD] fieldservice_stage_server_action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickrwilson patrickrwilson patrickrwilson approved these changes

@max3903 max3903 max3903 approved these changes

@brian10048 brian10048 Awaiting requested review from brian10048

@smangukiya smangukiya Awaiting requested review from smangukiya

Assignees

@osi-scampbell osi-scampbell

Labels
approved bug needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@osi-scampbell @max3903 @patrickrwilson @OCA-git-bot