Allow to start run-apps parallel to other apps #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knorth55
suggested changes
Jul 4, 2022
Affonso-Gui
force-pushed
the
enable-parallel-run-apps
branch
from
ba1a3ef to
677861b
Compare
|
Added some fixes |
This was referenced Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable to run simple apps (which use the run tag and don't have any plugins) parallel to other apps.
I am using this to add interrupt/resume buttons to the web interface (knorth55/jsk_robot#260), which can be activated during another task.
This could also be potentially useful for running battery checks, light on/off, and other kinds of quick scripts during demo execution.
The implementation still has some limitations: the parallel apps cannot be stopped by the web interface and as mentioned above cannot have any plugins or launch files. However, it should be a practical start towards a parallel web interface.
Currently under testing with the real robot. Will try to add more unit tests later too.
@knorth55