Migrate HC_SR04 class member variable initialization to declarations, augment code so that it compiles. #11857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
force-pushed
the
hc_sr04_work
branch
2 times, most recently
from
b59e7d7 to
3498919
Compare
This was referenced Apr 15, 2019
mcsauder
force-pushed
the
hc_sr04_work
branch
3 times, most recently
from
e192e97 to
1893af3
Compare
This was referenced Apr 23, 2019
mcsauder
force-pushed
the
hc_sr04_work
branch
3 times, most recently
from
29b9d4d to
83d2a1b
Compare
|
@teapethu , could you advise me on this driver? It is currently in a broken state. I've added code in this PR so that it compiles, but it appears to have been broken for at least the past year and a half. |
mcsauder
force-pushed
the
hc_sr04_work
branch
2 times, most recently
from
4f15bd5 to
9c0f013
Compare
mcsauder
force-pushed
the
hc_sr04_work
branch
4 times, most recently
from
e81d19c to
8c756d4
Compare
dagar
reviewed
Jun 16, 2019
|
|
||
| virtual ssize_t read(device::file_t *filp, char *buffer, size_t buflen); | ||
| virtual int ioctl(device::file_t *filp, int cmd, unsigned long arg); | ||
| virtual int ioctl(device::file_t *filp, int cmd, unsigned long arg) override; |
There was a problem hiding this comment.
Things like the ioctl, read, and ringbuffers can usually be gutted entirely. These were used historically to read directly from the device (eg ::open("/dev/distance_sensor0")), but all of that has moved entirely to orb.
mcsauder
force-pushed
the
hc_sr04_work
branch
2 times, most recently
from
5c6d1b5 to
a4205b9
Compare
mcsauder
force-pushed
the
hc_sr04_work
branch
2 times, most recently
from
980ff23 to
d4a3487
Compare
14 tasks
mcsauder
force-pushed
the
hc_sr04_work
branch
2 times, most recently
from
83cf755 to
059bfb1
Compare
mcsauder
force-pushed
the
hc_sr04_work
branch
from
6f7ee54 to
1414c8a
Compare
… list to declarations, format whitespace, and organize var declaration order.
mcsauder
force-pushed
the
hc_sr04_work
branch
from
1414c8a to
e27efe8
Compare
julianoes
reviewed
Sep 25, 2019
| if (hc_sr04::g_dev != nullptr) { | ||
| hc_sr04::g_dev->interrupt(time); | ||
| } | ||
| // static int sonar_isr(int irq, void *context); |
There was a problem hiding this comment.
Why is this commented out? Can it be removed?
| { | ||
| int ret = PX4_ERROR; | ||
| int ret = -EIO; | ||
| #if 0 |
There was a problem hiding this comment.
Why is this disabled? I would at least add a comment in code to explain why.
|
Closing in favor of #13021! |
This was referenced Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
This PR migrates HC_SR04 class member variable initialization to their respective declarations, formats whitespace, organizes variable ordering, and modifies the code so that it at least compiles, (it is very much still broken, however).
NOTE the hc_sr04 driver has been in a disfunctional state since prior to January 2018. This PR aims to align the driver with other distance sensor drivers, however it could easily be argued that this PR should be modified to deprecate the hc_sr04 driver entirely.
Describe your preferred solution
Ultimately all distance sensor drivers should inherit from a common base class, and this PR makes incremental steps toward that objective.
Describe possible alternatives
Deprecate this particular driver entirely.
Additional context
See Issue #9279.
NOTE: This driver is badly broken... A decision should be made about whether or not it should be fixed or deprecated.
https://www.mouser.com/ds/2/813/HCSR04-1022824.pdf
Please let me know if you have any questions on this PR. Thanks!
-Mark