Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update submodule ecl to latest Sun Oct 13 08:37:25 EDT 2019 #13175

Merged
merged 1 commit into from
Oct 27, 2019
Merged

Update submodule ecl to latest Sun Oct 13 08:37:25 EDT 2019 #13175

merged 1 commit into from
Oct 27, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Oct 13, 2019 

- ecl in PX4/Firmware (a1b8ce29f32c6430e8be21a6475f93055ab0a938): https://github.com/PX4/ecl/commit/f005e0ea8f33d10dd014a0700e712426540bb58a
- ecl current upstream: https://github.com/PX4/ecl/commit/eae6e8f19c0a587e54beea1bb461c8bb9aae4ccf
- Changes: https://github.com/PX4/ecl/compare/f005e0ea8f33d10dd014a0700e712426540bb58a...eae6e8f19c0a587e54beea1bb461c8bb9aae4ccf

eae6e8f 2019-08-06 Paul Riseborough - EKF: Fix on ground yaw drift when using EKF2_MAG_TYPE = 4
4e946d5 2019-09-04 RomanBapst - implemented synthesized magnetometer Z measurement - calculate a theoretical value based on the knowledge of the direction and strength of the magnetic field vector and X/Y sensor measurements - needs knowledge about location on earth to work

@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch 12 times, most recently from 4e3399a to c50e37c Compare October 19, 2019 12:38
@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch 5 times, most recently from 72b1124 to ec3e039 Compare October 22, 2019 13:25
@dagar
Copy link
Member Author

dagar commented Oct 22, 2019

Updated again by PX4Buildbot.

image

@dagar dagar requested a review from bresch October 22, 2019 13:35
@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch from ec3e039 to 7ae81f4 Compare October 23, 2019 00:37
bresch
bresch previously approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me.
@PX4/testflights Could you test this? If possible with a drone having a rangefinder and an optical flow sensor.

@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch from 7ae81f4 to 27fee8d Compare October 23, 2019 12:39
@nkadioglu nkadioglu changed the title Update submodule ecl to latest Sun Oct 13 08:37:25 EDT 2019 Update submodule ecl to latest Sun Oct 13 08:37:25 EDT 2019 [R3] Oct 23, 2019
@nkadioglu nkadioglu changed the title Update submodule ecl to latest Sun Oct 13 08:37:25 EDT 2019 [R3] Update submodule ecl to latest Sun Oct 13 08:37:25 EDT 2019 Oct 23, 2019
@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch 2 times, most recently from a6a136a to fdc8431 Compare October 24, 2019 12:39
@Tony3dr
Copy link

Tony3dr commented Oct 24, 2019

rangefinder and an optical flow sensor.
@bresch, unfortunately, we don't have vehicles with rangefinder or optical flow sensor.

@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch 5 times, most recently from b19cdea to 932c7d5 Compare October 27, 2019 00:40
@PX4BuildBot
Update submodule ecl to latest Sun Oct 27 12:38:03 UTC 2019
9ab9243 
    - ecl in PX4/Firmware (dcfe226): PX4/PX4-ECL@f005e0e
    - ecl current upstream: PX4/PX4-ECL@9b4b24e
    - Changes: PX4/PX4-ECL@f005e0e...9b4b24e

    9b4b24e 2019-10-17 RomanBapst - removed unused definition
0e3a0b8 2019-10-15 RomanBapst - range_finder_checks: parametrised signal quality hysteresis duration
16d1e15 2019-10-15 RomanBapst - addressed review comments
6bc6f26 2019-10-14 RomanBapst - range_finder_checks: set range height to valid if signal quality is non-zero
6299d81 2019-10-14 RomanBapst - ekf_helper: use latest validated range sample to reset height
00f49e6 2019-10-14 RomanBapst - cleanup checks of range finder data
4d37065 2019-08-22 Paul Riseborough - EKF: Make use of inverse rotation function consistent with name
36de2b3 2019-08-22 Paul Riseborough - EKF: Use matrix library for quaternion to rotation matrix conversion
1a4ab06 2019-10-22 bresch - rate controller: add override specifiers whenever needed
29f71ff 2019-10-21 bresch - ekf: Add override specifier for all functions that override virtual functions of the estimator interface class
50167bf 2019-10-16 bresch - estimator interface: add deprecated functions for backward compatibility
b38458c 2019-10-10 bresch - Terrain estimator: formatting and remove redundant comments
0aef0ed 2019-10-10 bresch - terrain_estimator: remove dead code. Since the terrain estimator is constantly reset on ground, it is not necessary anymore to fuse fake measurements on ground if the range measurements are bad.
370e04e 2019-10-03 bresch - terrain_est: Continuously reset terrain height on ground using known clearance. This is the best estimate as we should not rely on a distance sensor while on the ground. This also helps when the drone is carried over as it avoids starting with a crazy downward distance for optical flow scaling.
e09e3e1 2019-10-14 bresch - control: rename _range_aid_enabled to _is_range_aid_suitable rename rangeAidConditionsMet to checkRangeAidSuitability
fac69d0 2019-10-14 bresch - control: refactor rangeAidConditionsMet function
eae6e8f 2019-08-06 Paul Riseborough - EKF: Fix on ground yaw drift when using EKF2_MAG_TYPE = 4
4e946d5 2019-09-04 RomanBapst - implemented synthesized magnetometer Z measurement - calculate a theoretical value based on the knowledge of the direction and strength of the magnetic field vector and X/Y sensor measurements - needs knowledge about location on earth to work
@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch from 932c7d5 to 9ab9243 Compare October 27, 2019 12:38
@dagar
Copy link
Member Author

dagar commented Oct 27, 2019

It's riskier to let all of these unrelated ecl changes pile up and come in at once. I've checked all the ECL PRs accounted for here and they've all been tested individually to some extent. Merging.

@dagar dagar merged commit 17b654f into master Oct 27, 2019
@dagar dagar deleted the pr-update_src/lib/ecl branch October 27, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bresch bresch bresch left review comments

@RomanBapst RomanBapst Awaiting requested review from RomanBapst

@priseborough priseborough Awaiting requested review from priseborough

Assignees
No one assigned
Labels
Admin: Enhancement (improvement) 💡 EKF2 Tests (unit / functional) 🧪 Testing framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dagar @Tony3dr @bresch @nkadioglu @PX4BuildBot