This repository has been archived by the owner on May 1, 2024. It is now read-only.
control: refactor rangeAidConditionsMet function #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bresch
added
the
non-functional
|
@bresch Looks like a nice cleanup! Maybe you can rename "rangeAidConditionsMet" to "updateRangeAidEnabled" or "updateRangeAid" or something similar. The current name somehow makes me think that his function should return a boolean. |
RomanBapst
previously approved these changes
Oct 14, 2019
|
@bresch We need a test log where you can see the estimator switching in and out of range aid. |
bresch
force-pushed
the
pr-range-aid-condition
branch
from
b0bc69c to
b8c8355
Compare
rename rangeAidConditionsMet to checkRangeAidSuitability
bresch
force-pushed
the
pr-range-aid-condition
branch
from
9199a9d to
ef644c2
Compare
|
@RomanBapst I changed the names and I did a sitl test with boxes: https://logs.px4.io/plot_app?log=4bc72eb4-4d74-4aa2-a068-cae8828313e7 |
|
@RomanBapst Can you review again please? |
RomanBapst
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just because it took me way too long to read this function.
After this refactor, the comment at the top of the function is almost redundant, should we remove it?