Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PaddlePaddle Hackathon] add Squeezenet #36066

Merged
merged 26 commits into from
Nov 3, 2021
Merged

[PaddlePaddle Hackathon] add Squeezenet #36066

merged 26 commits into from
Nov 3, 2021

Conversation

fuqianya
Copy link
Contributor

@fuqianya fuqianya commented Sep 24, 2021

PR types

New features

PR changes

APIs

Describe

Add SqueezeNet to Paddle Vision (include calling of higher-level api, test case and doc).
Doc is at PaddlePaddle/docs#3919.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@fuqianya fuqianya changed the title add squeezenet [PaddlePaddle Hackathon] add Squeezenet Sep 29, 2021
@LielinJiang
Copy link
Contributor

代码冲突了,需要解决下。
请参考这个PR:#36070
提个下自测代码和精度,并且确认可以实例化两次

@fuqianya
Copy link
Contributor Author

代码冲突了,需要解决下。 请参考这个PR:#36070 提个下自测代码和精度,并且确认可以实例化两次

已自测,结果在 这里

@fuqianya
Copy link
Contributor Author

@LielinJiang 老师,这里麻烦重新review一下

@@ -0,0 +1,228 @@
# copyright (c) 2020 PaddlePaddle Authors. All Rights Reserve.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021

<https://arxiv.org/pdf/1602.07360.pdf>`_

Args:
version (str): version of squeezenet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

说明下version可以是哪些值?

@fuqianya
Copy link
Contributor Author

@LielinJiang 老师,已经进行了修改并过了CI.麻烦再review一下

LielinJiang
LielinJiang previously approved these changes Oct 21, 2021
TCChenlong
TCChenlong previously approved these changes Oct 27, 2021
XiaoguangHu01
XiaoguangHu01 previously approved these changes Oct 27, 2021
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TCChenlong
Copy link
Contributor

这个PR有些冲突哈,辛苦再处理下~

@fuqianya
Copy link
Contributor Author

这个PR有些冲突哈,辛苦再处理下~

好的,已处理~

@TCChenlong
Copy link
Contributor

@fuqianya 还是有点冲突哈

@fuqianya
Copy link
Contributor Author

fuqianya commented Nov 1, 2021

@fuqianya 还是有点冲突哈

恩恩,我解决一下,CI之前也一直没过。。

LielinJiang
LielinJiang previously approved these changes Nov 2, 2021
TCChenlong
TCChenlong previously approved these changes Nov 2, 2021
XiaoguangHu01
XiaoguangHu01 previously approved these changes Nov 2, 2021
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API


Examples:
.. code-block:: python

Copy link
Contributor

@TCChenlong TCChenlong Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI 未通过,这里少了一句 import paddle @fuqianya

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,我修改一下

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API

@TCChenlong
Copy link
Contributor

真不容易啊 请 @LielinJiang merge 下吧~

@LielinJiang LielinJiang merged commit e879425 into PaddlePaddle:develop Nov 3, 2021
ghost pushed a commit to piotrekobi/Paddle that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants