[ConvBert P0 P1 P2] Add PretrainedConfig, unit tests and input_embs #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov Report
@@ Coverage Diff @@
## develop #5886 +/- ##
===========================================
+ Coverage 61.94% 62.36% +0.42%
===========================================
Files 491 491
Lines 69136 69245 +109
===========================================
+ Hits 42824 43188 +364
+ Misses 26312 26057 -255
|
gongel
reviewed
May 11, 2023
| Examples: | ||
|
|
||
| ```python | ||
| >>> from paddlenlp.transformers import BertModel, BertConfig |
| @@ -0,0 +1,307 @@ | |||
| # Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
sijunhe
reviewed
May 12, 2023
Comment on lines
15
to
16
| from .modeling import * | ||
| from .tokenizer import * | ||
| # from .modeling import * | ||
| # from .tokenizer import * |
Comment on lines
767
to
776
| See :class:`ConvBertModel`. | ||
| output_hidden_states (bool, optional): | ||
| Whether to return the hidden states of all layers. | ||
| Defaults to `False`. | ||
| output_attentions (bool, optional): | ||
| Whether to return the attentions tensors of all attention layers. | ||
| Defaults to `False`. | ||
| return_dict (bool, optional): | ||
| Whether to return a :class:`~paddlenlp.transformers.model_outputs.QuestionAnsweringModelOutput` object. If | ||
| `False`, the output will be a tuple of tensors. Defaults to `False`. |
There was a problem hiding this comment.
这些应该也相应得补到ConvBertModel的注释里去
There was a problem hiding this comment.
已添加，此处均改为 “See :class:ConvBertModel.”
|
|
||
|
|
||
| @parameterized_class( | ||
| ("return_dict", "use_labels", "use_inputs_embeds"), |
There was a problem hiding this comment.
use_inputs_embeds 可以从parameterized里去了，在class定义里面直接打开use_inputs_embeds=True就好了
There was a problem hiding this comment.
已删去，设置 use_test_inputs_embeds: bool = True。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
PR changes
Description