🧑‍💻 New decimal-aware price system - Part 5: Convert instantiator functions from using Self to &self

[JuaniRios]

Main info on #260

• Since our price mechanism now has to call storage for the decimals, we need our price functions to be called not from the type, but from the type instance. i.e inst.calculate... and not Instantiator::calculate

• I took the liberty of converting all our functions also to using the instance (&self instead of Self), since usually the types are quite longer and doing inst. is easier.

[JuaniRios]

• ✅ New decimal-aware price system - Part 9: Fix Misc & Async tests #269 : 3 dependent PRs (#270 , #271 , #272 )
• ✅ New decimal-aware price system - Part 8: Fix Remainder tests #268
• ✅ New decimal-aware price system - Part 7: Fix Community tests #267
• ✅ New decimal-aware price system - Part 6: Fix auction tests #266
• 🧑‍💻 New decimal-aware price system - Part 5: Convert instantiator functions from using Self to &self #265 👈
• ⚗️ New decimal-aware price system - Part 4: Add evaluation test for different CT decimals #264
• ✅ New decimal-aware price system - Part 3: Fix evaluation tests #263
• ✅ New decimal-aware price system - Part 2: Fix application tests #262
• 💥 New decimal-aware price system - Part 1: Business Logic #260
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite

[vstam1]

I do not completely like the &self reference in each function, especially functions that do not need it like get_ed, but we can take a look at better structuring the instantiator after MVP

[JuaniRios]

Merge activity

• Apr 30, 9:52 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
• Apr 30, 9:59 AM EDT: Graphite rebased this pull request as part of a merge.
• Apr 30, 10:00 AM EDT: @JuaniRios merged this pull request with Graphite.