Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ New decimal-aware price system - Part 10: Fix integration tests #272

Merged
merged 1 commit into from
Apr 30, 2024
Merged

✅ New decimal-aware price system - Part 10: Fix integration tests #272

merged 1 commit into from
Apr 30, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Apr 30, 2024 •
edited
Loading

Main info on #260

  • This PR focuses on fixing the integration tests
  • While fixing I noticed and fixed an issue where the CT migration logic was doing the funding check with a hardcoded value instead of the actual CT amount minted. (by funding check I refer to checking that the polimec sovereign account has enough tokens on the project chain).

This was referenced Apr 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Apr 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Apr 30, 2024
Closed
@JuaniRios JuaniRios changed the title fix integration tests ✅ New decimal-aware price system - Part 10: Fix integration tests Apr 30, 2024
@JuaniRios JuaniRios force-pushed the 04-30-fix_integration_tests branch 5 times, most recently from 339e43a to 40eb0c9 Compare April 30, 2024 12:26
@JuaniRios JuaniRios self-assigned this Apr 30, 2024
@JuaniRios JuaniRios marked this pull request as ready for review April 30, 2024 12:26
lrazovic
lrazovic approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with few comments

@JuaniRios JuaniRios force-pushed the 04-30-fix_integration_tests branch 3 times, most recently from 13821e6 to b36a357 Compare April 30, 2024 13:16
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Apr 30, 2024 •
edited
Loading

Merge activity

  • Apr 30, 9:52 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Apr 30, 10:09 AM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 30, 10:10 AM EDT: @JuaniRios merged this pull request with Graphite.

Base automatically changed from 04-29-fix_misc_tests to main April 30, 2024 14:08
@JuaniRios JuaniRios merged commit 5933fa5 into main Apr 30, 2024
@JuaniRios JuaniRios deleted the 04-30-fix_integration_tests branch April 30, 2024 14:10
@lrazovic lrazovic mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic