Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ New decimal-aware price system - Part 6: Fix auction tests #266

Merged
merged 1 commit into from
Apr 30, 2024
Merged

✅ New decimal-aware price system - Part 6: Fix auction tests #266

merged 1 commit into from
Apr 30, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Apr 26, 2024 •
edited
Loading

Main info on #260

  • This PR focuses on fixing the auction tests

This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Apr 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Apr 26, 2024
Merged
@JuaniRios JuaniRios changed the title part 6 ✅ New decimal-aware price system - Part 3: Fix auction tests Apr 26, 2024
@JuaniRios JuaniRios changed the title ✅ New decimal-aware price system - Part 3: Fix auction tests ✅ New decimal-aware price system - Part 6: Fix auction tests Apr 26, 2024
vstam1
vstam1 reviewed Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could create a seperate PR that reorders the imports, const, types and structs in each file in the funding pallet.

@JuaniRios JuaniRios force-pushed the 04-26-part_6 branch 2 times, most recently from 4774f2b to 3981b5a Compare April 29, 2024 12:58
This was referenced Apr 29, 2024
Merged
Merged
Merged
@JuaniRios JuaniRios marked this pull request as ready for review April 29, 2024 15:47
@graphite-app Graphite App
Copy link

graphite-app bot commented Apr 29, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (04/29/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios mentioned this pull request Apr 30, 2024
Closed
vstam1
vstam1 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

This was referenced Apr 30, 2024
Closed
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Apr 30, 2024 •
edited
Loading

Merge activity

  • Apr 30, 9:52 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Apr 30, 10:01 AM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 30, 10:02 AM EDT: @JuaniRios merged this pull request with Graphite.

Base automatically changed from 04-26-fix_auction_tests to main April 30, 2024 14:00
@JuaniRios JuaniRios merged commit 9b80e26 into main Apr 30, 2024
@JuaniRios JuaniRios deleted the 04-26-part_6 branch April 30, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@lrazovic lrazovic Awaiting requested review from lrazovic

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @vstam1