feat(hogql): arrays and tuples #14986
Conversation
| select_query = ast.SelectQuery( | ||
| select=[node], select_from=ast.JoinExpr(table=ast.Field(chain=["events"])), ref=select_query_ref | ||
| ) | ||
| prepared_ast: ast.SelectQuery = cast( | ||
| ast.SelectQuery, | ||
| prepare_ast_for_printing(select_query, context=context, dialect=dialect, stack=[select_query]), | ||
| ) | ||
| return print_prepared_ast(prepared_ast.select[0], context=context, dialect=dialect, stack=[select_query]) |
There was a problem hiding this comment.
This translate_hogql function is only used to print HogQL filters inside legacy insights. There was a "undefined ref" bug that these lines fix. Basically we create a virtual "select" query, and print its first field. If the column itself got "swapped" (e.g. by adding toInt() around it), then the mutated object wouldn't get transferred into the previous virtual select. The changes above fix that --> now we prepare the entire query manually here, and then only print out the actual first select column.
Hope that makes sense 😅
| if stack: | ||
| # TODO: remove this kludge for old props | ||
| LazyTableResolver(stack=stack, context=context).visit(stack[-1]) |
There was a problem hiding this comment.
Without the previous hack in translate_hogql, we no longer need this hack 😅
posthog/hogql/ast.py
Outdated
| left: Expr | ||
| right: Expr |
There was a problem hiding this comment.
Why left and right instead of something more concrete like array and subscript?
There was a problem hiding this comment.
It was late and I was duplicating the exiting CompareOperation and BinaryOperation types. What you suggest makes sense. Renamed to array and property (opposed to subscript), as those were the strings I mostly used in code when passing values to left/right.
| @@ -319,6 +319,19 @@ class OrderExpr(Expr): | |||
| order: Literal["ASC", "DESC"] = "ASC" | |||
|
|
|||
|
|
|||
| class ArrayAccess(Expr): | |||
| array: Expr | |||
There was a problem hiding this comment.
Loose question: I wonder why we can't type this as Array?
There was a problem hiding this comment.
sometimes arrays are returned from elsewhere... e.g arrayMap(a->a*2, [1,2,2])[1]
* master: fix(flags): don't enclose in overall transaction so we get latest reads (#15003) fix(tests): make getEventsByPerson output stable to avoid flakes (#15009) feat(data-exploration): convert funnel correlation to data exploration (#14963) fix: Set hobby deployments to 'latest' by default (#14956) feat(hogql): lambdas (#14987) feat(hogql): arrays and tuples (#14986) fix(funnel): always use total step count for funnel chart label (#14993)
Changes
Support arrays and tuples in HogQL:
[]and(1, 2)How did you test this code?
Wrote tests for the parser and printer.