fix(flags): don't enclose in overall transaction so we get latest reads #15003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I'm not 100% if this is what's going wrong (this is terribly hard to reproduce); but my hypothesis now is that because of the overarching transaction, the read committed mode implies even when we restart the inner transaction, we're seeing the exact same things as before, so the exact same problem happens.
This PR breaks it down into one top level transaction only, which hopefully will resolve this problem.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?