Release 5.0.1 #135

Progi1984 · 2022-02-10T10:36:17Z

Questions	Answers
Description?	Release 5.0.1
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?	N/A
How to test?	Launch a release test

…tead of using customer_name

Co-authored-by: Simon G. <49909275+SimonGrn@users.noreply.github.com>

Bumps [prestashop/php-dev-tools](https://github.com/PrestaShop/php-dev-tools) from 3.16.0 to 3.16.1. - [Release notes](https://github.com/PrestaShop/php-dev-tools/releases) - [Commits](PrestaShop/php-dev-tools@v3.16.0...v3.16.1) --- updated-dependencies: - dependency-name: prestashop/php-dev-tools dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…ashop/php-dev-tools-3.16.1 Bump prestashop/php-dev-tools from 3.16.0 to 3.16.1

install version Good version

Fix js error since displayGDPRConsent

cs fixer cs fix

switch from deprecated 'header' hook to 'displayHeader'

Missing changes for displayHeader hook

Improved Workflow Build Release

Remove unused dependencies

To prevent google from indexing the icon names use data-icon and css to show the icons

Co-authored-by: GoT <PierreRambaud@users.noreply.github.com>

Fix upgrade module to v4

Customer anonymisation if reviews coming from version 3

Align rating to the left on product list

Improved Github Action (Support PHP 5.6 => 8.1)

TypeError on addCommentGrades in case of empty request

Renders author name with a link if it is a customer

saulaski

Only a few minor typos to fix

saulaski · 2022-02-10T10:52:06Z

controllers/front/ListComments.php

@@ -31,7 +31,7 @@ public function display()
    {
        $idProduct = (int) Tools::getValue('id_product');
        $page = (int) Tools::getValue('page', 1);
-        $isLastNameAnynomus = Configuration::get('PRODUCT_COMMENTS_ANONYMISATION');
+        $isLastNameAnonymous = Configuration::get('PRODUCT_COMMENTS_ANONYMISATION');


Suggested change

$isLastNameAnonymous = Configuration::get('PRODUCT_COMMENTS_ANONYMISATION');

$isLastNameAnonymous = (bool) Configuration::get('PRODUCT_COMMENTS_ANONYMISATION');

saulaski · 2022-02-10T10:56:16Z

controllers/front/PostComment.php

@@ -181,4 +183,31 @@ private function validateComment(ProductComment $productComment)

        return $errors;
    }
+
+    /**
+     * Valdiate criterions values


Suggested change

* Valdiate criterions values

* Validate criterion values

saulaski · 2022-02-10T11:01:00Z

controllers/front/PostComment.php

+     *
+     * @todo manage validation for criterion restricted on categories or products
+     *
+     * @param array $criterions


The plural form of "criterion" is "criteria", not "criterions"

saulaski · 2022-02-10T11:13:16Z

productcomments.php

+                'viewcustomer' => 1,
+            ]);
+
+            return '<a href="' . $linkToCustomerProfile . '">' . $value . '</a>';


Usually HTML escaping should be done here, not in the controller. But I understand changes should match legacy code.

PierreRambaud · 2022-02-10T12:54:58Z

Only a few minor typos to fix

Unfortunately, this is a release pull request, changes need to be applied in different pull request to update the dev branch :)

florine2623

Hello @Progi1984 ,

Thanks for the PR. Looking good to me, it is QA ✅

Progi1984 · 2022-02-10T15:06:45Z

Thanks @florine2623

jf-viguier and others added 30 commits January 5, 2021 11:23

if registered customer : return customer first name and last name ins…

48875b7

…tead of using customer_name

Update controllers/front/ListComments.php

6bccc7c

Co-authored-by: Simon G. <49909275+SimonGrn@users.noreply.github.com>

Update controllers/front/ListComments.php

6567b96

Co-authored-by: Simon G. <49909275+SimonGrn@users.noreply.github.com>

Merge pull request #120 from PrestaShop/dependabot/composer/dev/prest…

2167a53

…ashop/php-dev-tools-3.16.1 Bump prestashop/php-dev-tools from 3.16.0 to 3.16.1

Fix js error since displayGDPRConsent

cd03d75

Remove register hook

46182a6

install version Good version

Bump version

1d2316f

Merge pull request #121 from okom3pom/fix-js-error

b58b1bb

Fix js error since displayGDPRConsent

renders author name with a link if it is a customer

ac52bc7

cs fixer cs fix

To prevent google from indexing the icon names use data-icon

2eb87ff

switch from deprecated 'header' hook to 'displayHeader'

cc8dc62

move upgrade stuff to 5.0.1 as it is not released yet

9579985

Merge pull request #126 from tswfi/27129_fix_deprecated_hooks

d05fbcb

switch from deprecated 'header' hook to 'displayHeader'

Missing changes for displayHeader hook

e93a0f0

Merge pull request #127 from PierreRambaud/fix/header

060a176

Missing changes for displayHeader hook

Improved Workflow Build Release

ee75301

Remove unused dependencies

f413d1d

Merge pull request #128 from Progi1984/buildRelease

0db0dcd

Improved Workflow Build Release

Merge pull request #129 from atomiix/remove-unused-dependencies

b718ccd

Remove unused dependencies

Merge pull request #125 from tswfi/27007_material_icons

39cd065

To prevent google from indexing the icon names use data-icon and css to show the icons

Upgrade to 4 version : add hooks and conf

5f734da

Add default value to commentsPerPage

3e86e85

add constant

b7c5594

Configuration updateValue

cf0ba03

got's cast

fb2386c

Co-authored-by: GoT <PierreRambaud@users.noreply.github.com>

Merge pull request #107 from jf-viguier/fix-upgrade-v4

70fcd8b

Fix upgrade module to v4

Fix css of rating on product lists

5fec88e

Merge pull request #92 from jf-viguier/anonymisation-issue-oldmodule

23904e5

Customer anonymisation if reviews coming from version 3

TypeError on addCommentGrades in case of empty request

0ae7eea

clotairer and others added 7 commits January 31, 2022 15:33

Fix cs

f99935f

Merge pull request #130 from NeOMakinG/issue27252

9889b45

Align rating to the left on product list

Improved Github Action PHP

9446381

Fixed PHPStan

5322241

Merge pull request #134 from Progi1984/dev

52d1674

Improved Github Action (Support PHP 5.6 => 8.1)

Merge pull request #132 from clotairer/patch-1

d72ad58

TypeError on addCommentGrades in case of empty request

Merge pull request #124 from kpodemski/improvement/customer-link

33c089e

Renders author name with a link if it is a customer

Progi1984 added this to the 5.0.1 milestone Feb 10, 2022

Progi1984 requested a review from a team February 10, 2022 10:37

Progi1984 added the enhancement label Feb 10, 2022

PierreRambaud added the waiting for QA label Feb 10, 2022

saulaski suggested changes Feb 10, 2022

View reviewed changes

florine2623 approved these changes Feb 10, 2022

View reviewed changes

florine2623 added QA ✔️ and removed waiting for QA labels Feb 10, 2022

florine2623 self-assigned this Feb 10, 2022

Progi1984 merged commit b2586be into master Feb 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 5.0.1 #135

Release 5.0.1 #135

Progi1984 commented Feb 10, 2022

saulaski left a comment

saulaski Feb 10, 2022

saulaski Feb 10, 2022

saulaski Feb 10, 2022

saulaski Feb 10, 2022

PierreRambaud commented Feb 10, 2022

florine2623 left a comment

Progi1984 commented Feb 10, 2022

	$isLastNameAnonymous = Configuration::get('PRODUCT_COMMENTS_ANONYMISATION');
	$isLastNameAnonymous = (bool) Configuration::get('PRODUCT_COMMENTS_ANONYMISATION');

Release 5.0.1 #135

Release 5.0.1 #135

Conversation

Progi1984 commented Feb 10, 2022

saulaski left a comment

Choose a reason for hiding this comment

saulaski Feb 10, 2022

Choose a reason for hiding this comment

saulaski Feb 10, 2022

Choose a reason for hiding this comment

saulaski Feb 10, 2022

Choose a reason for hiding this comment

saulaski Feb 10, 2022

Choose a reason for hiding this comment

PierreRambaud commented Feb 10, 2022

florine2623 left a comment

Choose a reason for hiding this comment

Progi1984 commented Feb 10, 2022