Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider number of lanes to cross for Lane Anticipation #3025

Closed
daniel-j-h opened this issue Oct 10, 2016 · 0 comments
Closed

Consider number of lanes to cross for Lane Anticipation #3025

daniel-j-h opened this issue Oct 10, 2016 · 0 comments
Labels
Guidance
Milestone
5.6.0

Comments

@daniel-j-h
Copy link
Member

At the moment Lane Anticipation has a 15s threshold for two subsequent turns. Turns further apart than 15s are not considered for anticipation.

The idea is to change from a static 15s threshold only to considering the number of lanes to cross in addition: having to change from the leftmost lane across three lanes to the rightmost lane should be given a higher threshold for anticipation as simply changing one lane.
@daniel-j-h daniel-j-h added this to the 5.6.0 milestone Oct 14, 2016
daniel-j-h added a commit that referenced this issue Jan 3, 2017
@daniel-j-h
Consider number of lanes to cross, resolves #3025
cef9fd0
daniel-j-h added a commit that referenced this issue Jan 4, 2017
@daniel-j-h
Consider number of lanes to cross, resolves #3025.
487d8bc 
Lane Anticipation currently triggers on quick steps with lanes. This
changeset makes the "quick" part more dynamic by taking lanes left and
right of the turn into account. The reasoning for this is as follows.

The user can drive on the leftmost or rightmost lane and has to cross
all lanes left or right of the turn, respecitvely.

We scale our threshold appropriately, which now means the threshold
describes the duration the user needs for crossing _a single lane_.

Note: this is a heuristic and assumes the worst case. Which in my
opinion is fine to do since triggering Lane Anticipation in complex
scenarios is desirable.
@daniel-j-h daniel-j-h mentioned this issue Jan 4, 2017
Merged
2 tasks
daniel-j-h added a commit that referenced this issue Jan 4, 2017
@daniel-j-h
Consider number of lanes to cross, resolves #3025.
b80056b 
Lane Anticipation currently triggers on quick steps with lanes. This
changeset makes the "quick" part more dynamic by taking lanes left and
right of the turn into account. The reasoning for this is as follows.

The user can drive on the leftmost or rightmost lane and has to cross
all lanes left or right of the turn, respecitvely.

We scale our threshold appropriately, which now means the threshold
describes the duration the user needs for crossing _a single lane_.

Note: this is a heuristic and assumes the worst case. Which in my
opinion is fine to do since triggering Lane Anticipation in complex
scenarios is desirable.
daniel-j-h added a commit that referenced this issue Jan 4, 2017
@daniel-j-h
Consider number of lanes to cross, resolves #3025.
02202e2 
Lane Anticipation currently triggers on quick steps with lanes. This
changeset makes the "quick" part more dynamic by taking lanes left and
right of the turn into account. The reasoning for this is as follows.

The user can drive on the leftmost or rightmost lane and has to cross
all lanes left or right of the turn, respecitvely.

We scale our threshold appropriately, which now means the threshold
describes the duration the user needs for crossing _a single lane_.

Note: this is a heuristic and assumes the worst case. Which in my
opinion is fine to do since triggering Lane Anticipation in complex
scenarios is desirable.
@MoKob MoKob closed this as completed in b5d5f30 Jan 6, 2017
TheMarex pushed a commit that referenced this issue Jan 11, 2017
@daniel-j-h @TheMarex
Consider number of lanes to cross, resolves #3025.
6ea9f9f 
Lane Anticipation currently triggers on quick steps with lanes. This
changeset makes the "quick" part more dynamic by taking lanes left and
right of the turn into account. The reasoning for this is as follows.

The user can drive on the leftmost or rightmost lane and has to cross
all lanes left or right of the turn, respecitvely.

We scale our threshold appropriately, which now means the threshold
describes the duration the user needs for crossing _a single lane_.

Note: this is a heuristic and assumes the worst case. Which in my
opinion is fine to do since triggering Lane Anticipation in complex
scenarios is desirable.
raymond0 added a commit to raymond0/osrm-backend that referenced this issue Feb 24, 2017
@raymond0
Merged v5.5.4
ada276b 
Merge commit '54ab5373cf9b883f1d791182f218c33a2b5bd22b' into develop-ultimaterides-buildmain-integration

* commit '54ab5373cf9b883f1d791182f218c33a2b5bd22b': (23 commits)
  Fix tests - backported changes need old namespace.
  Update changelog and version for 5.5.4
  fix emitting invalid turn types, now surfacing due to changes in obvious detection
  Changelog Item for Project-OSRM#3561
  Added missing backward_speed for cycleways
  cherry-pick Project-OSRM#3555
  Fix possible division by zero by clamping latitude to 85.05°
  Adjusted number of `nodes` in `annotation`, resolves Project-OSRM#3515
  Update version and CHANGELOG for 5.5.3.
  Backport NumLanesToTheRight/NumLanesToTheLeft to support 6ea9f9f
  fix coordinate assertion for walking profile with steps
  Remove assertions that could be triggered by bad data. (Project-OSRM#3469)
  Make a hard reset of named barrier mutexes on signal
  Fix copying vector on std::sort comparator (Project-OSRM#3504)
  Consider number of lanes to cross, resolves Project-OSRM#3025.
  Make Travis buildit.
  Update changelog and version.
  Revert "Smarter search radius formula for map matching"
  Revert "Fix capture"
  Revert "Hardcode search radius parameters"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Guidance
Projects
None yet
Milestone
5.6.0
Development

No branches or pull requests
1 participant
@daniel-j-h