fix forks exiting a ferry, resolves #3536 #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMarex
changed the title
raymond0
added a commit
to raymond0/osrm-backend
that referenced
this pull request
Feb 24, 2017
Merge commit '54ab5373cf9b883f1d791182f218c33a2b5bd22b' into develop-ultimaterides-buildmain-integration * commit '54ab5373cf9b883f1d791182f218c33a2b5bd22b': (23 commits) Fix tests - backported changes need old namespace. Update changelog and version for 5.5.4 fix emitting invalid turn types, now surfacing due to changes in obvious detection Changelog Item for Project-OSRM#3561 Added missing backward_speed for cycleways cherry-pick Project-OSRM#3555 Fix possible division by zero by clamping latitude to 85.05° Adjusted number of `nodes` in `annotation`, resolves Project-OSRM#3515 Update version and CHANGELOG for 5.5.3. Backport NumLanesToTheRight/NumLanesToTheLeft to support 6ea9f9f fix coordinate assertion for walking profile with steps Remove assertions that could be triggered by bad data. (Project-OSRM#3469) Make a hard reset of named barrier mutexes on signal Fix copying vector on std::sort comparator (Project-OSRM#3504) Consider number of lanes to cross, resolves Project-OSRM#3025. Make Travis buildit. Update changelog and version. Revert "Smarter search radius formula for map matching" Revert "Fix capture" Revert "Hardcode search radius parameters" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR introduces a problem introduced in our fork refactor (#3264) /cc @chaupow
The error occurs on this node where a ferry enters a fork.
I cannot pin-point the exact location in the code that is responsible for this change, but I think it might be related to road-classification comparisons.
I've fixed multiple locations in the code:
forkentries is obvious due to the road class (the fork handler is currently miss-used to give better instructions thanturn straightfor both turns).Possible additional changes could be to incorporate the layer of the road, since we here see an intersection that technically is no intersection. I don't know how serious this problem is, though? Is this something worth ticketing? (Single Intersection with ferry, two roads, different layers of the ferry exiting).
Tasklist
Requirements / Relations
none