Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange annotation section during matching #3515

Closed
gardster opened this issue Jan 4, 2017 · 2 comments
Closed

Strange annotation section during matching #3515

gardster opened this issue Jan 4, 2017 · 2 comments
Assignees
Milestone

Comments

@gardster
Copy link
Contributor

gardster commented Jan 4, 2017

I made the matching request:

http://router.project-osrm.org/match/v1/car/-73.98082999996642,40.76764000000058;-73.98114000003697,40.76778000002791;-73.9814199999703,40.76829000001442;-73.98139000001274,40.768729999973914;-73.98120000004195,40.76906000000459?radiuses=6;7;4;4;5&annotations=true&steps=true&geometries=geojson&overview=full

In response I have one step with annotation:

"annotation": {
            "datasources": [
              0,
              0,
              0,
              0,
              0,
              0,
              0,
              0,
              0,
              0,
              0,
              0,
              0,
              0,
              0,
              0
            ],
            "nodes": [
              4347550074,
              1792535236,
              1792535234,
              1792535228,
              1825841670,
              1825841669,
              1825841747,
              1825841692,
              1825841744,
              4347550071,
              1825841654,
              1825841748,
              1825841647,
              1825841652,
              1825841687,
              4347550065,
              1825841752,
              1825841712
            ],
            "duration": [
              0.4,
              0.6,
              2.6,
              1,
              0.8,
              1.2,
              0.6,
              0.8,
              0.8,
              0.8,
              0.8,
              0.8,
              0.8,
              0.8,
              0.8,
              0.2
            ],
            "distance": [
              1.887799,
              3.242205,
              3.5787,
              5.318845,
              4.464822,
              6.502462,
              3.346855,
              4.311536,
              4.446879,
              4.449849,
              4.477669,
              4.45405,
              4.462612,
              4.448259,
              4.508641,
              1.90766
            ]
          }

There are 18 node ids and 16 distances, durations and datasources. But, as I understand, there must be 17 distances (for each node pairs).

@TheMarex
Copy link
Member

TheMarex commented Jan 5, 2017

Hrm, yes this looks weird. You are right this should be 17 and 16 respectively. Not sure what is going on here. Investigating.

@TheMarex TheMarex self-assigned this Jan 5, 2017
@TheMarex TheMarex added this to the 5.6.0 milestone Jan 5, 2017
@gardster
Copy link
Contributor Author

gardster commented Jan 9, 2017

Problem appears in both sides. For request:
https://router.project-osrm.org/match/v1/car/-73.96537000003526,40.75900000000774;-73.9659099999901,40.75874999999795?radiuses=12;16&annotations=true&steps=true&geometries=geojson&overview=full in response I got

            "datasources": [
              0,
              0
            ],
            "nodes": [
              42432861,
              42442960
            ],
            "duration": [
              5.7,
              0
            ],
            "distance": [
              52.70689,
              0.111226
            ]
          },

so there is durations records count more than expected.

daniel-j-h pushed a commit that referenced this issue Jan 17, 2017
raymond0 added a commit to raymond0/osrm-backend that referenced this issue Feb 24, 2017
Merge commit '54ab5373cf9b883f1d791182f218c33a2b5bd22b' into develop-ultimaterides-buildmain-integration

* commit '54ab5373cf9b883f1d791182f218c33a2b5bd22b': (23 commits)
  Fix tests - backported changes need old namespace.
  Update changelog and version for 5.5.4
  fix emitting invalid turn types, now surfacing due to changes in obvious detection
  Changelog Item for Project-OSRM#3561
  Added missing backward_speed for cycleways
  cherry-pick Project-OSRM#3555
  Fix possible division by zero by clamping latitude to 85.05°
  Adjusted number of `nodes` in `annotation`, resolves Project-OSRM#3515
  Update version and CHANGELOG for 5.5.3.
  Backport NumLanesToTheRight/NumLanesToTheLeft to support 6ea9f9f
  fix coordinate assertion for walking profile with steps
  Remove assertions that could be triggered by bad data. (Project-OSRM#3469)
  Make a hard reset of named barrier mutexes on signal
  Fix copying vector on std::sort comparator (Project-OSRM#3504)
  Consider number of lanes to cross, resolves Project-OSRM#3025.
  Make Travis buildit.
  Update changelog and version.
  Revert "Smarter search radius formula for map matching"
  Revert "Fix capture"
  Revert "Hardcode search radius parameters"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants