Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/bump to v0.30.0-alpha.5 #76

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Aug 3, 2024

Related Issue

#37

Summary of Changes

  1. Upgrade to v0.30.0-alpha.5 which helps address the following feature needs
  2. Update vite.config.js accordingly for new CSS behaviors
  3. Hoist ignores for ESLint since it wasn't actually ignoring output files

TODO

  1. Looks like we need to better guard standards CSS plugin intercepting to only CSS files - bug/issue 1257 refine standard CSS plugin intercepting greenwood#1262
    Parse error: Identifier is expected
    1 |export default {"footer":"footer-257057953-footer","logo":"footer-257057953-logo","socialTray":"fo…
    -----------------------^
    ^C
  2. Storybook is failing
    x Build failed in 493ms
    => Failed to build the preview
    TypeError: [transform-css-module-scripts] Could not load ./src/components/header/header.css.type (imported by src/components/header/header.js): Cannot destructure property 'projectDirectory' of 'compilation.context' as it is undefined.
        at bundleCss (file://./node_modules/@greenwood/cli/src/plugins/resource/plugin-standard-css.js:14:11)
        at StandardCssResource.intercept (file://./node_modules/@greenwood/cli/src/plugins/resource/plugin-standard-css.js:318:16)
        at Object.load (./vite.config.js:35:26)
        at async PluginDriver.hookFirstAndGetPlugin (file://./node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:19494:28)
        at async file://./node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:18665:33
        at async Queue.work (file://./node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:19704:32)
    transforming (496) node_modules/lodash/mapValues.js
  3. should probably thorough test against feature/issue 30 home page #57 - 960a5be

@thescientist13 thescientist13 added needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) chore project maintenance related tasks labels Aug 3, 2024
Copy link

netlify bot commented Aug 3, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit 3aafea1
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/66ba88d279a29c0008b91fbe
😎 Deploy Preview https://deploy-preview-76--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 merged commit 828a615 into main Aug 12, 2024
5 checks passed
@thescientist13 thescientist13 deleted the chore/greenwood-v0.30.0-alpha.5 branch August 12, 2024 22:14
@thescientist13 thescientist13 linked an issue Aug 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore project maintenance related tasks needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood)
Projects
Development

Successfully merging this pull request may close these issues.

upstream feature / fixes tracking
1 participant