Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/issue 1257 refine standard CSS plugin intercepting #1262

Merged
merged 1 commit into from
Aug 8, 2024
Merged

bug/issue 1257 refine standard CSS plugin intercepting #1262

merged 1 commit into from
Aug 8, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Aug 3, 2024 •
edited
Loading

Related Issue

#1257 / #1258

Noticed in the website project that CSS module scripts were getting treated as standard CSS files

Parse error: Identifier is expected
1 |export default {"footer":"footer-257057953-footer","logo":"footer-257057953-logo","socialTray":"fo…
-----------------------^
^C

Summary of Changes

  1. Improve "guard" for only standard CSS resources before intercepting in Greenwood's standards CSS plugin

TODO

  1. Should probably add a test case for this - this will be easier to reproduce as part of CSS Modules ™️ plugin #1233

@thescientist13 thescientist13 added bug Something isn't working CLI alpha.6 v0.30.0 labels Aug 3, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Aug 3, 2024
@thescientist13 thescientist13 linked an issue Aug 3, 2024 that may be closed by this pull request
CSS optimization workflow parity during development (inlining @import statements) #1257
Closed
@thescientist13 thescientist13 changed the title bug/issue 1257 refine standard css intercepting bug/issue 1257 refine standard CSS plugin intercepting Aug 3, 2024
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Aug 4, 2024
@thescientist13 thescientist13 mentioned this pull request Aug 8, 2024
Open
@thescientist13 thescientist13 merged commit 390d7a1 into release/0.30.0 Aug 8, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1257-refine-standard-css-intercepting branch August 8, 2024 01:27
This was referenced Aug 8, 2024
Draft
Open
Merged
@thescientist13 thescientist13 mentioned this pull request Sep 4, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alpha.6 bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.30.0
Projects
[Greenwood] Phase 9 - Standards and Conventions
Status: ✅ Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

CSS optimization workflow parity during development (inlining @import statements)
1 participant
@thescientist13