Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/upgrade greenwood v0.30.0-alpha.6 #87

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Sep 4, 2024

Related Issue

#37

Summary of Changes

  1. Unpatches support for
  2. Validates support for feature/issue 1268 import map and attribute polyfill configuration greenwood#1269

TODO

  1. hmmm... why is the build failing? (new node version in github actions?) - chore/upgrade greenwood v0.30.0-alpha.6 #87 (comment)
  2. upgrade to published v0.30.0-alpha.6 release / Undo patches and vendored acorn dependency
  3. rebase and validate against main

@thescientist13 thescientist13 added enhancement New feature or request chore project maintenance related tasks labels Sep 4, 2024
@thescientist13 thescientist13 self-assigned this Sep 4, 2024
@thescientist13 thescientist13 linked an issue Sep 4, 2024 that may be closed by this pull request
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit 1ca73df
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/66df23613523190008d10c34
😎 Deploy Preview https://deploy-preview-87--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13
Copy link
Member Author

thescientist13 commented Sep 6, 2024

So I upgraded to Node 18.20.4 locally, and was able to reproduce. And by doing a little logging, looks like the raw plugin is not processed the XML as a module now? Looks like it's just the XML being returned and not as an export

loading {
  source: 'file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/src/assets/discord.svg?type=raw',
  contents: '<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">\n' +
    '<path d="M19.3034 5.33716C17.9344 4.71103 16.4805 4.2547 14.9629 4C14.7719 4.32899 14.5596 4.77471 14.411 5.12492C12.7969 4.89144 11.1944 4.89144 9.60255 5.12492C9.45397 4.77471 9.2311 4.32899 9.05068 4C7.52251 4.2547 6.06861 4.71103 4.70915 5.33716C1.96053 9.39111 1.21766 13.3495 1.5891 17.2549C3.41443 18.5815 5.17612 19.388 6.90701 19.9187C7.33151 19.3456 7.71356 18.73 8.04255 18.0827C7.41641 17.8492 6.82211 17.5627 6.24904 17.2231C6.39762 17.117 6.5462 17.0003 6.68416 16.8835C10.1438 18.4648 13.8911 18.4648 17.3082 16.8835C17.4568 17.0003 17.5948 17.117 17.7434 17.2231C17.1703 17.5627 16.576 17.8492 15.9499 18.0827C16.2789 18.73 16.6609 19.3456 17.0854 19.9187C18.8152 19.388 20.5875 18.5815 22.4033 17.2549C22.8596 12.7341 21.6806 8.80747 19.3034 5.33716ZM8.5201 14.8459C7.48007 14.8459 6.63107 13.9014 6.63107 12.7447C6.63107 11.5879 7.45884 10.6434 8.5201 10.6434C9.57071 10.6434 10.4303 11.5879 10.4091 12.7447C10.4091 13.9014 9.57071 14.8459 8.5201 14.8459ZM15.4936 14.8459C14.4535 14.8459 13.6034 13.9014 13.6034 12.7447C13.6034 11.5879 14.4323 10.6434 15.4936 10.6434C16.5442 10.6434 17.4038 11.5879 17.3825 12.7447C17.3825 13.9014 16.5548 14.8459 15.4936 14.8459Z"/>\n' +
    '</svg>\n'
}
SyntaxError [Error]: Unexpected token '<'

Here are the last two NodeJS releases, nothing really stands out though 🤔


Ah, seemed to just be an issue on our end with some inconsistent patching - 68dd9e2

@thescientist13 thescientist13 reopened this Sep 6, 2024
@thescientist13 thescientist13 force-pushed the chore/upgrade-greenwood-0.30.0-alpha.6 branch from ddba794 to 07db73e Compare September 6, 2024 21:27
@thescientist13 thescientist13 marked this pull request as ready for review September 6, 2024 21:28
@thescientist13 thescientist13 force-pushed the chore/upgrade-greenwood-0.30.0-alpha.6 branch from 00fc59f to 1ca73df Compare September 9, 2024 16:33
@thescientist13 thescientist13 merged commit 65b24eb into main Sep 9, 2024
5 checks passed
@thescientist13 thescientist13 deleted the chore/upgrade-greenwood-0.30.0-alpha.6 branch September 9, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore project maintenance related tasks enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

upstream feature / fixes tracking
1 participant