This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Rebase patch1.70.1 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add space to JSDoc attributes
Fix problem switching from Uint16 to Uint32 indices for outlining.
Point cloud styling fixes
Added frustumSplits option to DebugCameraPrimitive
Simplify skinning to always expect VEC4 joint/weight accessors.
…m_depthClampFarPlane to czm_depthClamp
I was modifying gulpfile in another branch and realized formatting was not set up correctly.
…m ray ellipsoid intersection
Two small JSDoc/TS fixes
We were including all Cesium directories in the TypeScript smokescreen configuration. This meant that multiple Cesium.d.ts files were included if you did a full build and then ran `build-ts` afterwards. This updates the config used by the smokescreen to only include Source.
Fix for Node 14 Gulp Build issue
Exposing Transforms.rotationMatrixFromPositionVelocity
Add some missing readonly documentation tags
change cesiumScriptRegex value
Only include Source folder in TypeScript smokescreen tests.
Expose buildModuleUrl as part of the Cesium API
None of the `XXXGeometry` classes are actually `Geometry` instances. They
are instead utility classes that create geometries via their
`createGeometry` implementation. `GeometryInstance` can take either "type"
but since JS doesn't have types we never really defined what the "utility"
type is, so the TypeScript definition for `GeometryInstance` specifies that
currently only specifies `Geometry`. This means that this valid JS code
is a compiler error in TypeScript
```
const geometryInstance = new GeometryInstance({
geometry: new PolylineGeometry({
positions: [],
}),
});
```
To fix this, I introduced a `GeometryFactory` base class like we have
elsewhere in the code and changed `GeometryInstance` to take either type.
This is the only place where we actually base "non-geometry Geometry" in
the API.
Happy to consider other names, like `GeometryCreator` if we don't like
factory for some reason, but I want to get this in sooner rather than
later for 1.70.1 fixes.
Also fixed an issue with tsconfig.json I introduced in my last change
which was failing to actually catch TS compile errors because it wasn't
including the Cesium.d.ts.
Fix geometry creation in TypeScript
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.