Using config_provider for additional functionality exclusively #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lindnemi
approved these changes
Aug 6, 2024
for more information, see https://pre-commit.ci
toniseibold
added a commit
that referenced
this pull request
Aug 7, 2024
* using exclusively config_provider * moving bc to solving config * style changes * minor style changes * cosmetic changes * add back default values of constraints * remove unused function arguments * small fix for exporter * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Michael Lindner <michaellindner@posteo.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lindnemi
added a commit
that referenced
this pull request
Aug 9, 2024
* first stab at enabling H2 and H2 retrofit gas plants * forcing gas turbines from one year on * fixing efficiency of hydrogen gas turbines * bug fixing params * dropping gas plants after forcing them to retrofit * make unravelling of oil bus consistent with new refineries I.e. separate DE oil primary from DE oil. * update exporter * ci: add validator * select images and add repo owner path * Update PULL_REQUEST_TEMPLATE.md * Update Changelog.md * update submodule * Update .pre-commit-config.yaml * remove reuse check * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Using config_provider for additional functionality exclusively (#154) * using exclusively config_provider * moving bc to solving config * style changes * minor style changes * cosmetic changes * add back default values of constraints * remove unused function arguments * small fix for exporter * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Michael Lindner <michaellindner@posteo.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Create .git-blame-ignore-revs (#158) * minor changes for running single node network (#160) * minor changes for running single node network * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Fix hydrogen import boundary condition (#159) * include retrofitted and Kernnetz pipelines for hydrogen import boundary condition * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bugfixing mock_snakemake and fullfilling prerequisites for review --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * first stab at enabling H2 and H2 retrofit gas plants * forcing gas turbines from one year on * fix merge bugs * change exporter to report hydrogen plants * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change name of retrofitted H2 * updating exporter * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bus0 auf H2 plants * finish rename of h2 retrofit * default efficiency = 1 --------- Co-authored-by: Tom Brown <tom@nworbmot.org> Co-authored-by: Michael Lindner <michaellindner@posteo.de> Co-authored-by: lkstrp <lkstrp@pm.me> Co-authored-by: Micha <michaellindner@pik-potsdam.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Julian Geis <j.geis@tu-berlin.de>
6 tasks
toniseibold
added a commit
that referenced
this pull request
Sep 23, 2024
* first stab at enabling H2 and H2 retrofit gas plants * forcing gas turbines from one year on * fixing efficiency of hydrogen gas turbines * bug fixing params * dropping gas plants after forcing them to retrofit * make unravelling of oil bus consistent with new refineries I.e. separate DE oil primary from DE oil. * update exporter * ci: add validator * select images and add repo owner path * Update PULL_REQUEST_TEMPLATE.md * Update Changelog.md * update submodule * Update .pre-commit-config.yaml * remove reuse check * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Using config_provider for additional functionality exclusively (#154) * using exclusively config_provider * moving bc to solving config * style changes * minor style changes * cosmetic changes * add back default values of constraints * remove unused function arguments * small fix for exporter * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Michael Lindner <michaellindner@posteo.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Create .git-blame-ignore-revs (#158) * minor changes for running single node network (#160) * minor changes for running single node network * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Fix hydrogen import boundary condition (#159) * include retrofitted and Kernnetz pipelines for hydrogen import boundary condition * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bugfixing mock_snakemake and fullfilling prerequisites for review --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * first stab at enabling H2 and H2 retrofit gas plants * forcing gas turbines from one year on * fix merge bugs * change exporter to report hydrogen plants * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change name of retrofitted H2 * updating exporter * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bus0 auf H2 plants * finish rename of h2 retrofit * default efficiency = 1 --------- Co-authored-by: Tom Brown <tom@nworbmot.org> Co-authored-by: Michael Lindner <michaellindner@posteo.de> Co-authored-by: lkstrp <lkstrp@pm.me> Co-authored-by: Micha <michaellindner@pik-potsdam.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Julian Geis <j.geis@tu-berlin.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153
So far in
additional_functionality, thesnakemake.configwas used. However, when varying parameter specified inscenarios.automated.yaml, those parameters were not handed over properly.To fix this, in
solve_myopic.smk, the corresponding parameters are provided through the rule parameters using theconfig_provider(). This ensures that all the scenario parameters are handed over correctly.