-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydrogen Gas Turbines and Retrofitting of Gas Turbines #151
Conversation
if params["force"] >= year: | ||
logger.info("Retrofitting already forced.") | ||
|
||
if params["start"] <= year: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be elif?
Model results for 3H resolution KN2045_Bal_v4 scenario: |
I.e. separate DE oil primary from DE oil.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
* using exclusively config_provider * moving bc to solving config * style changes * minor style changes * cosmetic changes * add back default values of constraints * remove unused function arguments * small fix for exporter * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Michael Lindner <michaellindner@posteo.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* minor changes for running single node network * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* include retrofitted and Kernnetz pipelines for hydrogen import boundary condition * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bugfixing mock_snakemake and fullfilling prerequisites for review --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking very good, just two minor style suggestions then it can be merged
h2_plants.bus0 = h2_plants.bus0.str.replace("gas", "H2") | ||
h2_plants.bus2 = "" | ||
h2_plants.efficiency -= params["efficiency_loss"] | ||
h2_plants.efficiency2 = 1 # default value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a bit strange that the default value is 0 for H2 plants, but 1 for H2 retro plants
I just noticed that there are several more variables in the exporter that need to be adjusted, e.g. capacity|hydrogen and secondary energy input. basically all lines which have "H2 Fuel Cell" in master |
i updated the exporter however, the workflow is still failing because of a bug in |
plot_summary was failing because the H2 plants were connected to a non-existent I really wonder why the optimization went through at all and did not brake. @nworbmot @toniseibold In the 365H resolution no gas or H2 turbines get built. If this stays the same for 3H we will have to force in the Kraftwerkstrategie plants: The hydrogen capacity is all fuel cells at the moment. However, we do see urban central gas boilers being built. Maybe those should be retrofitted to H2 as well? |
Validator ReportI am the Validator. Download all artifacts here. Config Result plots comparison
Result files comparison
MAPE: Mean Absolute Percentage Error Comparing retrofit_gas_plants (67b8ffd) with main (d21a5c2). |
* first stab at enabling H2 and H2 retrofit gas plants * forcing gas turbines from one year on * fixing efficiency of hydrogen gas turbines * bug fixing params * dropping gas plants after forcing them to retrofit * make unravelling of oil bus consistent with new refineries I.e. separate DE oil primary from DE oil. * update exporter * ci: add validator * select images and add repo owner path * Update PULL_REQUEST_TEMPLATE.md * Update Changelog.md * update submodule * Update .pre-commit-config.yaml * remove reuse check * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Using config_provider for additional functionality exclusively (#154) * using exclusively config_provider * moving bc to solving config * style changes * minor style changes * cosmetic changes * add back default values of constraints * remove unused function arguments * small fix for exporter * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Michael Lindner <michaellindner@posteo.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Create .git-blame-ignore-revs (#158) * minor changes for running single node network (#160) * minor changes for running single node network * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Fix hydrogen import boundary condition (#159) * include retrofitted and Kernnetz pipelines for hydrogen import boundary condition * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bugfixing mock_snakemake and fullfilling prerequisites for review --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * first stab at enabling H2 and H2 retrofit gas plants * forcing gas turbines from one year on * fix merge bugs * change exporter to report hydrogen plants * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change name of retrofitted H2 * updating exporter * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bus0 auf H2 plants * finish rename of h2 retrofit * default efficiency = 1 --------- Co-authored-by: Tom Brown <tom@nworbmot.org> Co-authored-by: Michael Lindner <michaellindner@posteo.de> Co-authored-by: lkstrp <lkstrp@pm.me> Co-authored-by: Micha <michaellindner@pik-potsdam.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Julian Geis <j.geis@tu-berlin.de>
Adding the following configs
modify_prenetwork
config["start"]
onconfig["force"] is set, from the force year on, all OCGT, CCGT, gas CHPs links from
config["start"] on are dropped and only the hydrogen links existadditional_functionality
config["retrofit_CH4_to_H2"]["enable"]
is set, gas plant links and hydrogen retro links are added as a boundary condition in a way, that the installed capacity of both must be lower equal than the former installed capacity of gas plantsOpen issues: