Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor changes for running single node network #160

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

JulianGeis
Copy link
Contributor

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
  • One or several figures that validate the changes in the PR have been posted as a comment
  • A brief description of the changes has been added to Changelog.md
  • The latest main has been merged into the PR
  • The config has a new prefix of the format `YYYYMMDDdescriptivetitle

@lindnemi lindnemi merged commit f807830 into main Aug 7, 2024
2 checks passed
Copy link

github-actions bot commented Aug 7, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

Config
prefix: 240806oilrefineries

Result plots comparison
Base branch Feature branch
primary_energy.png Image not found Image not found
secondary_energy.png Image not found Image not found
final_energy.png Image not found Image not found
Result files comparison
Numeric Status NMAE MAPE
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/curtailment.csv 72.2% ⚠️Changed 0.08 1.32e+03%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/nodal_cfs.csv ⚠️ NaN mismatch
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/nodal_supply_energy.csv ⚠️ NaN mismatch
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/nodal_capacities.csv ⚠️ NaN mismatch
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/nodal_costs.csv ⚠️ NaN mismatch
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/capacities.csv 72.6% ✅ Almost equal 0.00 1.20e+07%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/cumulative_cost.csv 84.7% ✅ Almost equal 0.08 0.0%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/price_statistics.csv 57.1% ✅ Almost equal 0.06 0.9%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/supply_energy.csv 64.7% ✅ Almost equal 0.03 1.13e+08%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/energy.csv 72.9% ✅ Almost equal 0.02 2.02e+08%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/cfs.csv 72.3% ✅ Almost equal 0.05 12.9%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/costs.csv 65.1% ✅ Almost equal 0.02 6.57e+07%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/metrics.csv 54.5% ✅ Almost equal 0.07 3.3%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/supply.csv 64.7% ✅ Almost equal 0.01 1.05e+05%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/market_values.csv 77.9% ✅ Almost equal 0.07 1.2%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/prices.csv 81.1% ✅ Almost equal 0.00 1.6%
20240801offwindconnectioncosts/KN2045_Bal_v4/csvs/weighted_prices.csv ✅ Equal

MAPE: Mean Absolute Percentage Error
NMAE: Mean Absolute Error on Min-Max Normalized Data
Status Thresholds: NMAE > 0.05 and MAPE > 5%

Comparing single-cluster (4df7898) with main (d90aca1).
Branch is 3 commits ahead and 2 commits behind main.
Last updated on 2024-08-07 16:21:45 CEST.

toniseibold pushed a commit that referenced this pull request Aug 7, 2024
* minor changes for running single node network

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lindnemi added a commit that referenced this pull request Aug 9, 2024
* first stab at enabling H2 and H2 retrofit gas plants

* forcing gas turbines from one year on

* fixing efficiency of hydrogen gas turbines

* bug fixing params

* dropping gas plants after forcing them to retrofit

* make unravelling of oil bus consistent with new refineries

I.e. separate DE oil primary from DE oil.

* update exporter

* ci: add validator

* select images and add repo owner path

* Update PULL_REQUEST_TEMPLATE.md

* Update Changelog.md

* update submodule

* Update .pre-commit-config.yaml

* remove reuse check

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Using config_provider for additional functionality exclusively (#154)

* using exclusively config_provider

* moving bc to solving config

* style changes

* minor style changes

* cosmetic changes

* add back default values of constraints

* remove unused function arguments

* small fix for exporter

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Michael Lindner <michaellindner@posteo.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Create .git-blame-ignore-revs (#158)

* minor changes for running single node network (#160)

* minor changes for running single node network

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Fix hydrogen import boundary condition (#159)

* include retrofitted and Kernnetz pipelines for hydrogen import boundary condition

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* bugfixing mock_snakemake and fullfilling prerequisites for review

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* first stab at enabling H2 and H2 retrofit gas plants

* forcing gas turbines from one year on

* fix merge bugs

* change exporter to report hydrogen plants

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change name of retrofitted H2

* updating exporter

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix bus0 auf H2 plants

* finish rename of h2 retrofit

* default efficiency = 1

---------

Co-authored-by: Tom Brown <tom@nworbmot.org>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>
Co-authored-by: lkstrp <lkstrp@pm.me>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Julian Geis <j.geis@tu-berlin.de>
toniseibold added a commit that referenced this pull request Sep 23, 2024
* first stab at enabling H2 and H2 retrofit gas plants

* forcing gas turbines from one year on

* fixing efficiency of hydrogen gas turbines

* bug fixing params

* dropping gas plants after forcing them to retrofit

* make unravelling of oil bus consistent with new refineries

I.e. separate DE oil primary from DE oil.

* update exporter

* ci: add validator

* select images and add repo owner path

* Update PULL_REQUEST_TEMPLATE.md

* Update Changelog.md

* update submodule

* Update .pre-commit-config.yaml

* remove reuse check

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Using config_provider for additional functionality exclusively (#154)

* using exclusively config_provider

* moving bc to solving config

* style changes

* minor style changes

* cosmetic changes

* add back default values of constraints

* remove unused function arguments

* small fix for exporter

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Michael Lindner <michaellindner@posteo.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Create .git-blame-ignore-revs (#158)

* minor changes for running single node network (#160)

* minor changes for running single node network

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Fix hydrogen import boundary condition (#159)

* include retrofitted and Kernnetz pipelines for hydrogen import boundary condition

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* bugfixing mock_snakemake and fullfilling prerequisites for review

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* first stab at enabling H2 and H2 retrofit gas plants

* forcing gas turbines from one year on

* fix merge bugs

* change exporter to report hydrogen plants

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change name of retrofitted H2

* updating exporter

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix bus0 auf H2 plants

* finish rename of h2 retrofit

* default efficiency = 1

---------

Co-authored-by: Tom Brown <tom@nworbmot.org>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>
Co-authored-by: lkstrp <lkstrp@pm.me>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Julian Geis <j.geis@tu-berlin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants