Pulse sim tests #379
Merged
Pulse sim tests #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating `Qobj` to the new `QasmQobj`
* Fixes MacOS unresolved symbol problem at runtime, when building with gcc * Fixes MacOS unresolved symbols at runtime when building with clang++
Refactor qubitvector indexing
* Update QuantumError, ReadoutError to work with QuantumChannel * update tests
* Update QuantumError, ReadoutError to work with QuantumChannel * update tests
Rename "ch" method to "extended_stabilizer"
use ThreadPoolExecutor for all systems
* fix apply_matrix2 vectorization order * add check if 1-qubit mat in apply_matrix * fix indexes lambda functions * add qubit checks for apply_matrix2 etc
* Minor refactoring of Standalone exit code paths
(Windows) * Refactor some code from the Extended Stabilizer
add auto-configuration of threads for qasm simulator
* add multi-controlled pauli gates * implement cx, cz as mcx, mcz * add multi controlled u1,u2,u3 gates * fixup indexes refs * update changelog
taalexander
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
Looks good to me! Thanks for the hard work and changes @zachschoenfeld33!
dcmckayibm
reviewed
Oct 25, 2019
dcmckayibm
reviewed
Oct 26, 2019
|
Great job, definitely on the right track. A few things to discuss. |
atilag
reviewed
Oct 26, 2019
…aer into pulse-sim-tests
…aer into pulse-sim-tests
atilag
approved these changes
Nov 3, 2019
There was a problem hiding this comment.
I'm approving this, but I'd leave to @dcmckayibm or/and @taalexander to decide when this is ready.
This is going to be very helpfull for my refactor, which is about to be finished, so the faster we ca
n merge this the better :)
|
@atilag can you merge #420 and then @zachschoenfeld33 can you make sure your tests are updated so they work? |
|
Should be quick |
|
#420 merged. @zachschoenfeld33 you can rebase with |
|
Tests are fixed! |
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
Add Pulse Simulator tests
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
Add Pulse Simulator tests
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
Add Pulse Simulator tests
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
Add Pulse Simulator tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds high level tests for open pulse simulator.
Details and comments
Note: does not provide unit tests; just high level tests of features.