Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test script: cycle tab #2

Merged
merged 2 commits into from
May 27, 2022
Merged

Test script: cycle tab #2

merged 2 commits into from
May 27, 2022

Conversation

gabalafou
Copy link
Collaborator

@gabalafou gabalafou commented May 14, 2022 •
edited
Loading

No description provided.

@gabalafou
Copy link
Collaborator Author

gabalafou commented May 14, 2022 •
edited
Loading

Here are some screenshots of how the test failures look in Playwright with this additional test.

image

image

If you watch the video that Playwright produces, you can actually see Playwright tabbing across the JupyterLab UI wherever it lands on elements that have visible focus, and then it just tabs off to nowhere.

@gabalafou gabalafou mentioned this pull request May 14, 2022
Closed
@trallard trallard self-assigned this May 17, 2022
@trallard trallard self-requested a review May 17, 2022 16:29
@gabalafou gabalafou changed the base branch from axe-gitpod to master May 18, 2022 21:37
@gabalafou gabalafou mentioned this pull request May 18, 2022
Closed
@isabela-pf isabela-pf mentioned this pull request May 19, 2022
Merged
9 tasks
trallard added a commit that referenced this pull request May 19, 2022
@trallard
ENH: Update noxfile and env (#2)
733ca04
@gabalafou gabalafou mentioned this pull request May 19, 2022
Closed
@trallard
Copy link
Member

@trallard check in GitPod

trallard
trallard approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - managed to run this on Gitpod and all seems to be working ok 👍🏽

is there any more work needed atm?

@gabalafou gabalafou marked this pull request as ready for review May 27, 2022 15:24
@gabalafou
Copy link
Collaborator Author

is there any more work needed atm?

Nope. All good to merge. I simply forgot to take the PR out of draft mode earlier.

@gabalafou gabalafou merged commit a26df3c into master May 27, 2022
@gabalafou gabalafou deleted the a11y-test-no-keyboard-trap branch May 27, 2022 15:26
@gabalafou
Copy link
Collaborator Author

gabalafou commented May 27, 2022 •
edited
Loading

I just merged this into the main branch. So next step is... use the same branch of this PR (a11y-test-no-keyboard-trap) to open a new pull request against jupyter/accessibility?

@trallard
Copy link
Member

Pull Request from this repo master into jupyter/accessibility master to avoid having diverging histories 😉

@gabalafou
Copy link
Collaborator Author

@trallard like this? jupyter#92

@trallard
Copy link
Member

Yes - we need to merge #5 before merging to avoid issues with the GH actions

@trallard
Copy link
Member

Now that #5 is merged we can mark your PR as ready 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trallard trallard trallard approved these changes

Assignees

@trallard trallard

Labels
area: testing ✅ czi-grant PR: ready for merge 💪🏾
Projects
Jupyter a11y CZI grant 🚀
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabalafou @trallard