Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitpod updates + new Playwright test #92

Merged
merged 37 commits into from
Jun 23, 2022
Merged

Conversation

gabalafou
Copy link
Collaborator

@gabalafou gabalafou commented May 27, 2022

This is just a sync of the main/master branches from Quansight-Labs to juptyer

@trallard trallard added type: enhancement 💅🏼 New feature or request type: maintenance 🔨 Keeping this project up to date area: testing 🔍 Items related to accessibility testing labels May 27, 2022
@gabalafou gabalafou marked this pull request as ready for review June 13, 2022 15:29
@gabalafou gabalafou requested a review from trallard June 14, 2022 07:49
@gabalafou
Copy link
Collaborator Author

But is this the way we want to do it? @isabela-pf proposed an alternative workflow.

In her workflow, you create two PRs sequentially. First you create one against Quansight-Labs, and wait for it to be approved and merged, then you create a second PR against jupyter, like so:

  1. First merge Quansight-Labs/accessibility:feature-branch via first PR into Quansight-Labs/accessibility:main
  2. Then merge Quansight-Labs/accessibility:feature-branch via second PR into jupyter/accessibility:main

@trallard trallard merged commit ed2254d into jupyter:main Jun 23, 2022
@trallard
Copy link
Member

yup that is what we set onto last time

@trallard trallard deleted the master branch June 27, 2022 15:04
gabalafou added a commit to gabalafou/accessibility that referenced this pull request Jul 21, 2022
Revert "Merge pull request jupyter#92 from Quansight-Labs/master"

This reverts commit ed2254d, reversing
changes made to 87e4467.
gabalafou added a commit to gabalafou/accessibility that referenced this pull request Jul 21, 2022
Revert "Merge pull request jupyter#92 from Quansight-Labs/master"

This reverts commit ed2254d, reversing
changes made to 87e4467.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing 🔍 Items related to accessibility testing type: enhancement 💅🏼 New feature or request type: maintenance 🔨 Keeping this project up to date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants