Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neo4j-arc should be node/rel-ID agnostic #22

Merged
merged 3 commits into from
Nov 22, 2023
Merged

neo4j-arc should be node/rel-ID agnostic #22

merged 3 commits into from
Nov 22, 2023

Conversation

QubitPi
Copy link
Owner

@QubitPi QubitPi commented Nov 22, 2023 •
edited
Loading

Changelog

Added

Changed

  • A recent neo4j-library reuse exposed a design flaw in previous on-canvas operation. Realizing that node/rel ID's are generated by Neo4J database, I conclude that generating in-memory ID during on-canvas operation is a mistake. neo4j-arc is not responsible for generating or managing node/rel ID's; those ID must be federated externally such as DB auto-ID or client who uses the neo4j-arc library. This PR improves the design by changing those old ID's to transient ID's which are needed immediately by constructing on-canvas node/rels.

Deprecated

Removed

Fixed

Security

Checklist

  • Test
  • Self-review
  • Documentation
  • (neo4j-arc) Manually bump version

@QubitPi QubitPi self-assigned this Nov 22, 2023
@QubitPi QubitPi force-pushed the arc-does-not-generate-id branch from 88e6cc3 to 533760d Compare November 22, 2023 04:17
@QubitPi QubitPi force-pushed the arc-does-not-generate-id branch from 533760d to 2b3d5e4 Compare November 22, 2023 04:18
@QubitPi QubitPi merged commit ef331cd into master Nov 22, 2023
12 checks passed
@QubitPi QubitPi deleted the arc-does-not-generate-id branch November 22, 2023 06:04
QubitPi added a commit that referenced this pull request Nov 22, 2023
@QubitPi
neo4j-arc should be node/rel-ID agnostic (#22)
68b63d6 
* neo4j-arc should be node/rel-ID agnostic

* Update documentation

* Version bump
@QubitPi QubitPi mentioned this pull request Nov 22, 2023
Merged
4 tasks
QubitPi added a commit that referenced this pull request Dec 11, 2023
@QubitPi
neo4j-arc should be node/rel-ID agnostic (#22)
bdc678d 
* neo4j-arc should be node/rel-ID agnostic

* Update documentation

* Version bump
QubitPi added a commit that referenced this pull request Jun 11, 2024
@QubitPi
neo4j-arc should be node/rel-ID agnostic (#22)
0ff9e96 
* neo4j-arc should be node/rel-ID agnostic

* Update documentation

* Version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QubitPi QubitPi

Labels
BUG MERGEABLE REFACTORING
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@QubitPi