Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-canvas node creation is done by sending message only #26

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

QubitPi
Copy link
Owner

@QubitPi QubitPi commented Nov 22, 2023

Changelog

Added

Changed

  • neo4j-arc should be node/rel-ID agnostic #22 raised a question: if node/rel id is transient, then on-canvas relationship creation won't work because the source and target ID needs to be persisted ID's which is not possible with transient ID still exist on canvas. We must update DB first and trigger a re-rendering. In the same time therefore, Support double-clicking canvas creates new node #7 is not the optimal way of implementing double-clicking

    • We will trigger a new frame for re-rendering

Deprecated

Removed

Fixed

Security

Checklist

  • Test
  • Self-review
  • Documentation
  • (neo4j-arc) Manually bump version

@QubitPi QubitPi force-pushed the optimize-on-canvas-operations branch from fc967d8 to 1a34967 Compare November 22, 2023 12:35
@QubitPi QubitPi merged commit 644fac9 into master Nov 22, 2023
12 checks passed
@QubitPi QubitPi deleted the optimize-on-canvas-operations branch November 22, 2023 13:30
QubitPi added a commit that referenced this pull request Dec 11, 2023
* On-canvas node creation is done by sending message only

* Update E2E tests

* Update documentation

* version bump
QubitPi added a commit that referenced this pull request Jun 11, 2024
* On-canvas node creation is done by sending message only

* Update E2E tests

* Update documentation

* version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant