Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support double-clicking canvas creates new node #7

Merged
merged 8 commits into from
Oct 5, 2023

Conversation

QubitPi
Copy link
Owner

@QubitPi QubitPi commented Oct 3, 2023

This is not the optimal implementation. See #26 for a better one

Changelog

Added

  • Double-clicking canvas would create a new node

Changed

Deprecated

Removed

Fixed

Security

Checklist

  • Test
  • Self-review
  • Documentation

Reference

Lessons Learned

  • Do not test your tests on CI/CD; it's slow and inefficient. Take the advantage of fast local testing, which makes debugging much faster

@QubitPi QubitPi force-pushed the create-on-canvas-node branch from 12665c0 to b70438d Compare October 5, 2023 02:00
@QubitPi QubitPi force-pushed the create-on-canvas-node branch from b70438d to 3d595da Compare October 5, 2023 02:00
@QubitPi QubitPi force-pushed the create-on-canvas-node branch 2 times, most recently from 26ac160 to 7f457d8 Compare October 5, 2023 03:35
@QubitPi QubitPi force-pushed the create-on-canvas-node branch from 7f457d8 to 0ff132e Compare October 5, 2023 03:36
@QubitPi QubitPi merged commit c25b0e8 into master Oct 5, 2023
11 checks passed
@QubitPi QubitPi deleted the create-on-canvas-node branch October 5, 2023 05:08
QubitPi added a commit that referenced this pull request Nov 7, 2023
* Support double-clicking canvas creates new node

* Double clicking can make a node on canvas, although not at clicking position

* New nodes takes the max ID automatically

* add label in order to have node name displayed

* Node can be persisted into DB with simple config

* add better error handling and documentations

* add tests & documentation

* Self-review
QubitPi added a commit that referenced this pull request Nov 19, 2023
* Support double-clicking canvas creates new node

* Double clicking can make a node on canvas, although not at clicking position

* New nodes takes the max ID automatically

* add label in order to have node name displayed

* Node can be persisted into DB with simple config

* add better error handling and documentations

* add tests & documentation

* Self-review
QubitPi added a commit that referenced this pull request Nov 22, 2023
* Support double-clicking canvas creates new node

* Double clicking can make a node on canvas, although not at clicking position

* New nodes takes the max ID automatically

* add label in order to have node name displayed

* Node can be persisted into DB with simple config

* add better error handling and documentations

* add tests & documentation

* Self-review
QubitPi added a commit that referenced this pull request Dec 11, 2023
* Support double-clicking canvas creates new node

* Double clicking can make a node on canvas, although not at clicking position

* New nodes takes the max ID automatically

* add label in order to have node name displayed

* Node can be persisted into DB with simple config

* add better error handling and documentations

* add tests & documentation

* Self-review
QubitPi added a commit that referenced this pull request Jun 11, 2024
* Support double-clicking canvas creates new node

* Double clicking can make a node on canvas, although not at clicking position

* New nodes takes the max ID automatically

* add label in order to have node name displayed

* Node can be persisted into DB with simple config

* add better error handling and documentations

* add tests & documentation

* Self-review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant