Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/rust: Remove duplicate (and wrong) line #17700

Merged

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Feb 24, 2022

Doc fix: Some line duplication happened already in the initial version, and when 17504 had the --locked added, the opportunity to remove the duplication was missed.

Issues/PRs references

This obsoletes #17694 which would solve half of that line's problem (the missing --locked; the other is that it's not installing from the checked-out source)

Later #17536 will touch this all again, but that's still waiting for a CI update and for a full test run.

The duplication happened already in the initial version, and when
[17504] had the `--locked` added, the opportunity to remove the
duplication was missed.

[17504]: RIOT-OS#17504
@chrysn chrysn requested a review from JKRhb February 24, 2022 15:56
@github-actions github-actions bot added the Area: doc Area: Documentation label Feb 24, 2022
@chrysn chrysn added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 24, 2022
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@chrysn chrysn added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Feb 24, 2022
@kaspar030 kaspar030 enabled auto-merge February 24, 2022 15:58
@JKRhb
Copy link
Member

JKRhb commented Feb 24, 2022

Thank you! I'll close #17694 then :)

@kaspar030 kaspar030 merged commit fa450ee into RIOT-OS:master Feb 24, 2022
@chrysn chrysn deleted the doc-c2rust-double-line branch February 24, 2022 18:01
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants