EXSWHTEC-109 - Implement tests for the hipModuleLoad family of APIs and hipModuleUnload #20
Conversation
music-dino
commented
Dec 7, 2022
•
music-dino
commented
- Implement positive and negative tests for hipModuleLoad
- Implement positive and negative tests for hipModuleLoadData
- Implement positive and negative tests for hipModuleLoadDataEx
- Implement positive tests for hipModuleUnload as part of the above tests
- Implement negative tests for hipModuleUnload.
Change-Id: I66f0c09e9c7405ec7430b1883e0e89542fdb87a0
Change-Id: I212b82b1b3a78a368b85ea64e338371a34b405f9
Change-Id: Ib455f72b5be77e1a81137d15c07ea41161b16a3e
Change-Id: Ief96e274f4143e80ceb3e40f04d38ae217777583
Change-Id: I9c03cde09b42c8e3726153c2a177359efc8d6d29
…nd hipModuleUnload - Basic positive tests - Negative parameter tests
…hipModuleLoad_tests
catch/unit/module/CMakeLists.txt
Outdated
| add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/empty_module.code | ||
| COMMAND ${CMAKE_CXX_COMPILER} --genco --std=c++17 ${CMAKE_CURRENT_SOURCE_DIR}/empty_module.cc -o empty_module.code | ||
| DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/empty_module.cc) |
There was a problem hiding this comment.
genco does not work properly on windows yet. you will need to exclude this test building on windows. additionally you are missing specifying the offload arch & output path for building the code object. see unit/deviceLib/CMakeLists.txt for an example of how to do it for all of the above.
There was a problem hiding this comment.
Requested changes have been implemented, please proceed.
… path for code object build command
catch/unit/module/hipModuleLoad.cc
Outdated
| } | ||
|
|
||
| // Disabled for AMD due to defect - EXSWHTEC-151 | ||
| #if HT_NVIDIA |
There was a problem hiding this comment.
Create a new TEST_CAST for this and disable it via json.
There was a problem hiding this comment.
The requested change has been implemented.
| } | ||
|
|
||
| // Disabled for AMD due to defect - EXSWHTEC-153 | ||
| #if HT_NVIDIA |
There was a problem hiding this comment.
The requested change has been implemented.
| } | ||
|
|
||
| // Disabled for AMD due to defect - EXSWHTEC-153 | ||
| #if HT_NVIDIA |
There was a problem hiding this comment.
The requested change has been implemented.
catch/unit/module/hipModuleUnload.cc
Outdated
| HIP_CHECK(hipFree(nullptr)); | ||
|
|
||
| // Disabled for AMD due to defect - EXSWHTEC-152 | ||
| #if HT_NVIDIA |
There was a problem hiding this comment.
The requested change has been implemented.
catch/unit/module/not_a_module.txt
Outdated
There was a problem hiding this comment.
is the empty file necessary?
There was a problem hiding this comment.
The test requires a file that exists in the filesystem, but does not represent a valid module file. This seemed like the most straightforward approach.
…ail on AMD and NVIDIA and disable them via JSON
|
@rorake I don't see your comment for some reason, so I cannot quote reply to it. Merge conflicts have been resolved, please proceed. |
|
PR has been merged into develop branch via commit 2c6d940. |
…nd hipModuleUnload #20 Change-Id: I19d6534af2c33046dc3862372d45f32b6ccc6ad1
