Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXSWHTEC-97 - Implement tests for hipMemcpy2D APIs #53

Closed
wants to merge 17 commits into from
Closed

EXSWHTEC-97 - Implement tests for hipMemcpy2D APIs #53

wants to merge 17 commits into from

Conversation

mirza-halilcevic
Copy link
Contributor

  • Implement basic behavior checks in all copy directions
  • Implement synchronization behavior checks for expected behavior based on cuda docs
  • Implement positive tests for zero sized width and/or height copies, where no copy is expected to happen
  • Implement negative parameter tests
  • Implement all of the above for hipMemcpy2D and hipMemcpy2DAsync.

gargrahul and others added 9 commits October 26, 2022 03:59
@gargrahul
SWDEV-355313 - Move catch tests and samples
cea96af 
Change-Id: I66f0c09e9c7405ec7430b1883e0e89542fdb87a0
@gargrahul
SWDEV-355313 - Add README
909e7e4 
Change-Id: I212b82b1b3a78a368b85ea64e338371a34b405f9
@gargrahul
SWDEV-355313 - Update amd-staging branch
094b9af 
Change-Id: Ib455f72b5be77e1a81137d15c07ea41161b16a3e
@gargrahul
SWDEV-355313 - Update README
9daa6d0 
Change-Id: Ief96e274f4143e80ceb3e40f04d38ae217777583
@gargrahul
SWDEV-355313 - Update latest code
c49043e 
Change-Id: I9c03cde09b42c8e3726153c2a177359efc8d6d29
@nives-vukovic
EXSWHTEC-94 - Add resource guards and utils for 2D/3D allocations and…
98fdac0 
… arrays

- Add resource guards for 2D and 3D allocations
- Add resource guards for arrays
- Add utils for hadling pitched memory
- Add hip_array_common.hh to gather type, size and format mapping
@nives-vukovic
Merge remote-tracking branch 'origin/develop' into utils
12e34b9
@nives-vukovic
EXSWHTEC-94 - Extend stream guard and add guards for multiple events …
15614ba 
…and streams
@mirza-halilcevic
EXSWHTEC-97 - Implement tests for hipMemcpy2D APIs
9ba5337 
- Implement basic behavior checks in all copy directions
- Implement synchronization behavior checks for expected behavior based on cuda docs
- Implement positive tests for zero sized width and/or height copies, where no copy is expected to happen
- Implement negative parameter tests
- Implement all of the above for hipMemcpy2D and hipMemcpy2DAsync.
This was referenced Dec 9, 2022
Closed
Closed
@jaydeeppatel1111
Copy link
Contributor

Memcpy2DHtoHSyncBehavior with malloc case is fixed and will be available in upcoming release. however We should use async version of API to get async behavior for DD. i.e. Memcpy2DDtoDSyncBehavior can be fixed through test case change. Currently tests use sync version of API for DD that can be changed to Async version. True, Which is perhaps not matching to cuda however we have decided to keep it as is. Please update test cases and let us know if there is any issue. Thanks
@chrispaquot @mangupta

@milos-mozetic milos-mozetic mentioned this pull request Dec 28, 2022
Open
@mirza-halilcevic
Copy link
Contributor Author

Memcpy2DHtoHSyncBehavior with malloc case is fixed and will be available in upcoming release. however We should use async version of API to get async behavior for DD. i.e. Memcpy2DDtoDSyncBehavior can be fixed through test case change. Currently tests use sync version of API for DD that can be changed to Async version. True, Which is perhaps not matching to cuda however we have decided to keep it as is. Please update test cases and let us know if there is any issue. Thanks @chrispaquot @mangupta

The test case is now updated.

@rorake
Copy link
Contributor

rorake commented Jun 21, 2023

@mirza-halilcevic
Will you please resolve the merge conflicts for this PR?

rocm-ci pushed a commit that referenced this pull request Feb 26, 2024
@mirza-halilcevic @rakesroy
EXSWHTEC-97 - Implement tests for hipMemcpy2D APIs #53
c9e664b 
Change-Id: I674741e641b1ebd6adb5c60c05c2d8ade27510c6
rocm-ci pushed a commit that referenced this pull request Feb 26, 2024
@rakesroy
SWDEV-1 - Merge github PRs to amd-staging
96df1fd 
- #119
- #151
- #57
- #58
- #59
- #60
- #99
- #139
- #152
- #48
- #54
- #53
- #24
- #23
- #22
- #21
- #20
- #14
- #8

Change-Id: I1eea54cd1436f3ddbfd5c1b3b2f672eb81d03cd4
@rakesroy
Copy link
Contributor

PR has been merged into develop branch via commit c9e664b.

@rakesroy rakesroy closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispaquot chrispaquot chrispaquot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mirza-halilcevic @jaydeeppatel1111 @rorake @rakesroy @chrispaquot @gargrahul @nives-vukovic