Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXSWHTEC-80 - Implement tests for hipModuleGetGlobal #23

Closed
wants to merge 13 commits into from
Closed

EXSWHTEC-80 - Implement tests for hipModuleGetGlobal #23

wants to merge 13 commits into from

Conversation

music-dino
Copy link
Contributor

@music-dino music-dino commented Dec 7, 2022 •
edited
Loading

  • Implement positive tests to check basic behavior for globals of different types
  • Implement positive and negative parameter tests.

gargrahul and others added 7 commits October 26, 2022 03:59
@gargrahul
SWDEV-355313 - Move catch tests and samples
cea96af 
Change-Id: I66f0c09e9c7405ec7430b1883e0e89542fdb87a0
@gargrahul
SWDEV-355313 - Add README
909e7e4 
Change-Id: I212b82b1b3a78a368b85ea64e338371a34b405f9
@gargrahul
SWDEV-355313 - Update amd-staging branch
094b9af 
Change-Id: Ib455f72b5be77e1a81137d15c07ea41161b16a3e
@gargrahul
SWDEV-355313 - Update README
9daa6d0 
Change-Id: Ief96e274f4143e80ceb3e40f04d38ae217777583
@gargrahul
SWDEV-355313 - Update latest code
c49043e 
Change-Id: I9c03cde09b42c8e3726153c2a177359efc8d6d29
@music-dino
Create common code for module tests
580df9d
@music-dino
EXSWHTEC-80 - Implement tests for hipModuleGetGlobal
0e719cb 
- Basic positive tests
- Negative parameter tests
@milos-mozetic milos-mozetic mentioned this pull request Dec 19, 2022
Open
chrispaquot
chrispaquot requested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@chrispaquot chrispaquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having so many #if HT_NVIDIA, can you remove them and put the tests in the json file to avoid running them?

@music-dino
Copy link
Contributor Author

Instead of having so many #if HT_NVIDIA, can you remove them and put the tests in the json file to avoid running them?

As far as I am aware, there is no way to skip individual sections via the json, only entire test cases.

@chrispaquot
Copy link
Contributor

Instead of having so many #if HT_NVIDIA, can you remove them and put the tests in the json file to avoid running them?

As far as I am aware, there is no way to skip individual sections via the json, only entire test cases.

@mangupta What should we do here then? Or just skip the whole test for now?

@chrispaquot
Copy link
Contributor

Instead of having so many #if HT_NVIDIA, can you remove them and put the tests in the json file to avoid running them?

As far as I am aware, there is no way to skip individual sections via the json, only entire test cases.

OK so instead, create new a new TEST_CASE for the failing ones.

@music-dino
Copy link
Contributor Author

Instead of having so many #if HT_NVIDIA, can you remove them and put the tests in the json file to avoid running them?

As far as I am aware, there is no way to skip individual sections via the json, only entire test cases.

OK so instead, create new a new TEST_CASE for the failing ones.

The requested change has been implemented.

@rakesroy
Copy link
Contributor

@music-dino ,
Will you please resolve the merge conflicts in this PR?

@rakesroy
Copy link
Contributor

PR has been merged into develop branch via commit ce7e67a.

@rakesroy rakesroy closed this Feb 26, 2024
rocm-ci pushed a commit that referenced this pull request Feb 26, 2024
@mirza-halilcevic @rakesroy
EXSWHTEC-80 - Implement tests for hipModuleGetGlobal #23
ce7e67a 
Change-Id: I873ef5c977ec252425b81e3ed7ea33c861277efb
rocm-ci pushed a commit that referenced this pull request Feb 26, 2024
@rakesroy
SWDEV-1 - Merge github PRs to amd-staging
96df1fd 
- #119
- #151
- #57
- #58
- #59
- #60
- #99
- #139
- #152
- #48
- #54
- #53
- #24
- #23
- #22
- #21
- #20
- #14
- #8

Change-Id: I1eea54cd1436f3ddbfd5c1b3b2f672eb81d03cd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispaquot chrispaquot chrispaquot requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@music-dino @chrispaquot @rakesroy @gargrahul @milos-mozetic @mirza-halilcevic