-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mac/focal yaml serialization differs from bionic's #13541
Comments
Ideally, the I/O code could be set to use the flow style during serialization, because it's nicer to read. We do that for C++ already: drake/common/yaml/yaml_write_archive.cc Lines 29 to 37 in e55b6dd
|
Amen on the nicer-to-read. |
Ooh, a tribool found in the wild. Get out the documentary cameras. |
* pyyaml changed its default flow semantics in yaml/pyyaml#256 * We must override the default with the magic tribool value `None` * Fixes RobotLocomotion#13541
* pyyaml changed its default flow semantics in yaml/pyyaml#256 * We must override the default with the magic tribool value `None` * Fixes RobotLocomotion#13541
* Force older and newer yaml.dump to give the same output * pyyaml changed its default flow semantics in yaml/pyyaml#256 * We must override the default with the magic tribool value `None` * Fixes #13541
For whatever reason, yaml serialization on mac and focal produces vertically formatted lists, while serialization on bionic produces horizontally formatted ones. This produces errors like
The relevant test was nerfed in #13538 but should be rewritten to compare the parsed (or post-parse serialized) rather than a raw reference serialized form in its roundtrip tests (ie, to insist on semantic rather than syntactic equality).
The text was updated successfully, but these errors were encountered: