Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python bind CalcCenterOfMassTranslationalVelocity/Acceleration() #21730

Conversation

mitiguy
Copy link
Contributor

@mitiguy mitiguy commented Jul 18, 2024

PR #21710 created C++ code for the new function Multibody::CalcCenterOfMassTranslationalAccelerationInWorld(), which is work towards issue #14269.

This PR creates Python bindings for this new function along with the older C++ function Multibody::CalcCenterOfMassTranslationalVelocityInWorld() (which is missing Python bindings).


This change is Reviewable

mitiguy

This comment was marked as resolved.

@sherm1
Copy link
Member

sherm1 commented Jul 19, 2024

Per f2f discussion, this line in the message above is the likely cause:

RuntimeError: This method doesn't support T = Expression.

Copy link
Contributor Author

@mitiguy mitiguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature review +@sherm1

Reviewable status: LGTM missing from assignee sherm1(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @mitiguy)

@mitiguy mitiguy changed the title [WIP] Python bind CalcCenterOfMassTranslationalVelocity/Acceleration() Python bind CalcCenterOfMassTranslationalVelocity/Acceleration() Jul 19, 2024
Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature :lgtm:
+@SeanCurtis-TRI for platform review per rotation, please

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @mitiguy)

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @mitiguy)

@SeanCurtis-TRI SeanCurtis-TRI added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Jul 22, 2024
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: squashing now)

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees SeanCurtis-TRI(platform),sherm1(platform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium release notes: feature This pull request contains a new feature status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants