Python binding for Body::CalcCenterOfMassTranslationalVelocityInWorld(). #21926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitiguy
added
priority: medium
status: do not review
release notes: feature
mitiguy
changed the title
mitiguy
commented
Sep 18, 2024
There was a problem hiding this comment.
For both reviews
Feature review +@xuchenhan-tri
Platform review +@xuchenhan-tri
Reviewable status: LGTM missing from assignee xuchenhan-tri(platform)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee xuchenhan-tri(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python bindings for C++ public functions RigidBody::CalcCenterOfMassTranslationalVelocityInWorld()
and RigidBody::CalcCenterOfMassTranslationalAccelerationInWorld() .
Perhaps these Python bindings could have been done as part of issue #14269. However, binding RigidBody::CalcCenterOfMassTranslationalVelocityInWorld() was overlooked a while ago and binding RigidBody::CalcCenterOfMassTranslationalAccelerationInWorld() was delayed to this PR.
This change is